wxGUI gcp: fix checking vector map existence in the group (#680)

OSGeo · Jul 25, 2020 · 61e3e5f · 61e3e5f
1 parent 27c352f
commit 61e3e5f
Showing 1 changed file with 16 additions and 13 deletions.
diff --git a/gui/wxpython/gcp/manager.py b/gui/wxpython/gcp/manager.py
@@ -893,22 +893,25 @@ def OnEnterPage(self, event=None):
                                     self.parent.grouppage.xygroup,
                                     'VREF')
 
-            f = open(vgrpfile)
+            error_message = _(
+                'No maps in selected group <%s>.\n'
+                'Please edit group or select another group.') % \
+                self.parent.grouppage.xygroup
+
             try:
-                for vect in f.readlines():
-                    vect = vect.strip('\n')
-                    if len(vect) < 1:
-                        continue
-                    self.parent.src_maps.append(vect)
-            finally:
-                f.close()
+                with open(vgrpfile) as f:
+                    for vect in f.readlines():
+                        vect = vect.strip('\n')
+                        if len(vect) < 1:
+                            continue
+                        self.parent.src_maps.append(vect)
+            except FileNotFoundError:
+                GError(parent=self, message=error_message,
+                       showTraceback=False)
+                return
 
             if len(self.parent.src_maps) < 1:
-                GError(
-                    parent=self, message=_(
-                        'No maps in selected group <%s>.\n'
-                        'Please edit group or select another group.') %
-                    self.parent.grouppage.xygroup)
+                GError(parent=self, message=error_message)
                 return
 
         # filter out all maps not in group