Skip to content

Commit

Permalink
CI: Update labeler’s labels (#3349)
Browse files Browse the repository at this point in the history 
* CI: Update labeler’s labels

* Update labeler.yml

* Update labeler.yml

Co-authored-by: Markus Neteler <neteler@osgeo.org>

* labeler: Add missing module categories and map scripts

* labeler: remove Markdown label as it is included in docs label

---------

Co-authored-by: Markus Neteler <neteler@osgeo.org>
  • Loading branch information
@echoix @neteler
echoix and neteler committed Jan 11, 2024
1 parent 51ec9b2 commit f7650a9
Showing 1 changed file with 96 additions and 22 deletions.
118 changes: 96 additions & 22 deletions .github/labeler.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,54 +20,131 @@ module:
- scripts/**/*
- temporal/**/*
- vector/**/*
vector:

# Module categories
database:
- changed-files:
- any-glob-to-any-file:
- db/**/*
- lib/db/**/*
- scripts/db.*/**
display:
- changed-files:
- any-glob-to-any-file:
- display/**/*
- lib/display/**/*
- scripts/d.*/**
general:
- changed-files:
- any-glob-to-any-file:
- general/**/*
- scripts/g.*/**
GUI:
- changed-files:
- any-glob-to-any-file:
- gui/**/*
imagery:
- changed-files:
- any-glob-to-any-file:
- imagery/**/*
- lib/imagery/**/*
- scripts/i.*/**
misc:
- changed-files:
- any-glob-to-any-file: vector/**/*
- any-glob-to-any-file:
- misc/**/*
- scripts/m.*/**
raster:
- changed-files:
- any-glob-to-any-file: raster/**/*
- any-glob-to-any-file:
- raster/**/*
- lib/raster/**/*
- scripts/r.*/**
raster3d:
- changed-files:
- any-glob-to-any-file:
- raster3d/**/*
- lib/raster3d/**/*
- scripts/r3.*/**
temporal:
- changed-files:
- any-glob-to-any-file: temporal/**/*
database:
- any-glob-to-any-file:
- temporal/**/*
- lib/temporal/**/*
- scripts/t.*/**
vector:
- changed-files:
- any-glob-to-any-file: db/**/*
GUI:
- any-glob-to-any-file:
- vector/**/*
- lib/vector/**/*
- scripts/v.*/**

# Build, packaging, or OS related
CI:
- changed-files:
- any-glob-to-any-file: gui/**/*
- any-glob-to-any-file:
- .github/**/*
- .travis/**/*
- binder/**
- .travis.yml
- renovate.json
- .pre-commit-config.yaml
Windows:
- changed-files:
- any-glob-to-any-file: mswindows/**/*
- any-glob-to-any-file:
- mswindows/**/*
macOS:
- changed-files:
- any-glob-to-any-file: macosx/**/*
- any-glob-to-any-file:
- macosx/**/*
Linux:
- changed-files:
- any-glob-to-any-file: singularity/**/*
- any-glob-to-any-file:
- singularity/**/*
- rpm/**
docker:
- changed-files:
- any-glob-to-any-file: docker/**/*
- any-glob-to-any-file:
- docker/**/*
- '**/*Dockerfile*'
- '**/*dockerfile*'
- '*Dockerfile*'
- '*dockerfile*'
- .dockerignore

docs:
- changed-files:
- any-glob-to-any-file:
- doc/**/*
- man/**/*
- '**/*.md'
- '**/*.rst'
- '**/*.html'
- '**/*.dox'
- '**/*.png'
- '**.cff'
- CITING
- CHANGES
- AUTHORS
- NEWS
- TODO
- all-globs-to-all-files:
- '!doc/development/rfc/*'
RFC:
- changed-files:
- any-glob-to-any-file: doc/development/rfc/*
- any-glob-to-any-file:
- doc/development/rfc/*
translation:
- changed-files:
- any-glob-to-any-file: locale/**/*
CI:
- changed-files:
- any-glob-to-any-file:
- .github/**/*
- .travis/**/*

# based on file types
Python:
- changed-files:
- any-glob-to-any-file: '**/*.py'
- any-glob-to-any-file:
- '**/*.py'
- '**/pyproject.toml'
- 'pyproject.toml'
C:
- changed-files:
- any-glob-to-any-file: '**/*.c'
Expand All @@ -83,6 +160,3 @@ HTML:
JavaScript:
- changed-files:
- any-glob-to-any-file: '**/*.js'
Markdown:
- changed-files:
- any-glob-to-any-file: '**/*.md'

3 comments on commit f7650a9

@nilason
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echoix If you look at the commit message, you'll see what I mean by the importance of rewording the merge commit.

@echoix
Copy link
Member Author

@echoix echoix commented on f7650a9 Jan 11, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly would you like to point out? I see that the history that ended up in this commit is preserved even though it’s a squashed commit, the reference to the PR for later investigations is there, the title starts with a tag that is understood for release notes and all contributions that enhanced the original submission are correctly attributed

@nilason
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are four repetitive lines:

* CI: Update labeler’s labels

* Update labeler.yml

* Update labeler.yml

Co-authored-by: Markus Neteler <neteler@osgeo.org>

and "Update labeler.yml" is totally uninformative.

It is not the history behind how the final commit evolves that is important for the future of the project, it is what and perhaps why the final merge commit brings.
If you see the log of a branch, say the main, THAT is telling/preserving the history of the project. Looking from that (branch/project) perspective it is quite uninteresting how many times you "updated labeler.yml", "applied black", "reverted thisorthat" etc., only what that commit actually changed and perhaps why.

There is a document on commit messages which originate from pre-git versioning systems, but largely holds today. Also may I suggest browse around for "commit message good practice".

Please sign in to comment.