Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Make Display related toolbars part of Display tab #1189

Closed
wenzeslaus opened this issue Dec 19, 2020 · 1 comment · Fixed by #1321
Closed

[Feat] Make Display related toolbars part of Display tab #1189

wenzeslaus opened this issue Dec 19, 2020 · 1 comment · Fixed by #1321
Assignees
@lindakladivova
Labels
enhancement New feature or request GUI wxGUI related
Projects
Single Window Layout GUI

Comments

@wenzeslaus
Copy link
Member

Suggestion

Move the two toolbars which are related to Display (added map layers, and/or Map Display) from the Layer Manager window main tool bar to the Display tab (panel). This:

  • makes it consistent with Data tab which has its own toolbar which operates on the things in the tab,
  • makes the main toolbar smaller which possibly highlights its content,
  • groups adding layers with the operations on the added layers together,
  • avoids the new issue created by Data tab re-using the "pencil" icon to allow editing of other mapsets (now user sees two of these icons above each other which is strange), and
  • avoids the confusion when Data tab is active and a user clicks the Show attribute... button which is associated with selected layer in Displays, not selected vector map in Data tab.

However, unfortunately this makes the main toolbar longer by little less than one tool bar button width (exact measure depends on the system). This can be mitigated by merging Tools Toolbar and Misc Toolbar which may save few pixels and it might be a good idea to do that anyway.

Details

The toolbar names are Data Toolbar and Vector Toolbar and they should be included in that order.

Mockups

Display tab active

The two toolbars are part of the Display tab/panel. Created by just moving the toolbars around (the small toolbar with help and settings is missing in the picture).

Screenshot from 2020-12-18 22-20-36

Data tab active

The toolbars are not visible because they not part of the main toolbar. Created by removing the toolbars from the window.

Screenshot from 2020-12-18 22-22-55
@wenzeslaus wenzeslaus added enhancement New feature or request GUI wxGUI related labels Dec 19, 2020
@Ashutoshmitra
Copy link

I want to work on this issue.

@Ashutoshmitra Ashutoshmitra removed their assignment Feb 10, 2021
@lindakladivova lindakladivova self-assigned this Feb 10, 2021
@petrasovaa petrasovaa linked a pull request Feb 11, 2021 that will close this issue
wxGUI: Make Display related toolbars part of Display tab #1321
Merged
wenzeslaus pushed a commit that referenced this issue Mar 24, 2021
@lindakladivova
wxGUI: Make Display related toolbars part of Display tab (#1321)
802b3c8 
* The toolbar Data Toolbar and Vector Toolbar buttons are only visible for Display tab.
  - The buttons operate on the items in the Display tab.
  - Avoids the new issue created by Data tab re-using the "pencil" icon to allow editing of other mapsets
    (before this PR, user sees two of these icons above each other which is strange).
  - Avoids the confusion when Data tab is active and a user clicks the Show attribute... button
    which is associated with selected layer in Displays, not selected vector map in Data tab.
2. The new Data Toolbar now contains also NewDisplay button making the main toolbar a bit shorter than Display toolbar.

Fixes #1189.
@wenzeslaus wenzeslaus added this to To do in Single Window Layout GUI via automation Jun 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022
@lindakladivova @ninsbl
wxGUI: Make Display related toolbars part of Display tab (OSGeo#1321)
ee601c4 
* The toolbar Data Toolbar and Vector Toolbar buttons are only visible for Display tab.
  - The buttons operate on the items in the Display tab.
  - Avoids the new issue created by Data tab re-using the "pencil" icon to allow editing of other mapsets
    (before this PR, user sees two of these icons above each other which is strange).
  - Avoids the confusion when Data tab is active and a user clicks the Show attribute... button
    which is associated with selected layer in Displays, not selected vector map in Data tab.
2. The new Data Toolbar now contains also NewDisplay button making the main toolbar a bit shorter than Display toolbar.

Fixes OSGeo#1189.
ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023
@lindakladivova @ninsbl
wxGUI: Make Display related toolbars part of Display tab (OSGeo#1321)
26ee67f 
* The toolbar Data Toolbar and Vector Toolbar buttons are only visible for Display tab.
  - The buttons operate on the items in the Display tab.
  - Avoids the new issue created by Data tab re-using the "pencil" icon to allow editing of other mapsets
    (before this PR, user sees two of these icons above each other which is strange).
  - Avoids the confusion when Data tab is active and a user clicks the Show attribute... button
    which is associated with selected layer in Displays, not selected vector map in Data tab.
2. The new Data Toolbar now contains also NewDisplay button making the main toolbar a bit shorter than Display toolbar.

Fixes OSGeo#1189.
@wenzeslaus wenzeslaus moved this from To do to Done in Single Window Layout GUI Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindakladivova lindakladivova

Labels
enhancement New feature or request GUI wxGUI related
Projects
No open projects
Single Window Layout GUI
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

wxGUI: Make Display related toolbars part of Display tab lindakladivova/grass
3 participants
@wenzeslaus @lindakladivova @Ashutoshmitra