Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] wxGUI: Redesigning Map Display status bar combo box into a new Map Display Settings dialog #2017

Closed
11 tasks
lindakarlovska opened this issue Dec 14, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request GUI wxGUI related
Milestone

Comments

@lindakarlovska
Copy link
Contributor

lindakarlovska commented Dec 14, 2021

Is your feature request related to a problem? Please describe.

Today's state of Map Display statusbar is unsatisfactory especially in terms of the planned Single-Window mode. However, the truth is that it hasn't changed for a very long time, so it is kind of obsolete also in terms of Multi-Window mode.
The main problem is that the status bar is overloaded because in addition to the status bar function, it also performs the function of a local Map Display settings. The current state of Map Display frame is captured in the following picture:

Screenshot from 2021-12-13 01-29-45

The status bar at the bottom contains an extensive combo box that allows you to display static text items - such as Coordinates, Map window extent, Computational region extent. However, it also allows you to check several check boxes that relate to the local settings of the given map display. A list of all 10 items sorted by widget types can be seen here:

Text widgets:
old coords
old extent
old computational
old geometry

Check box widgets:
old show_extent
old align
old constrain
old projection

  • the check box item is also the Render check box, which is located on the right side of the status bar

Other widgets:
old map scale
old goto

Describe the solution you'd like

We need to shorten the status bar to suit the Single-Window mode which allows the display of map displays side by side. This means removing the combo box and putting in the status bar preferably only items that really have the character "status" - could be Map Scale, Coordinates, Extent, Computational region, Display geometry and newly Coordinate system. The other items of the combo box and the Render check box could be part of the new Map Display settings dialog. Additionally, the Go to item may be combined with the Coordinates item.

The new Map Display Settings settings, which could be part of the top toolbar, could include the following topics and check boxes:


Customize map:

  • Enable auto-rendering
  • Show computational extent
  • Align region extent based on display size
  • Constrain display resolution to computational settings
  • Use defined projection

Customize status bar:

  • Show map scale
  • Show coordinates
  • Show window extent
  • Show computational region extent
  • Show display geometry
  • Show coordinates system – new option

(Btw: the names for the individual check box items are probably quite confusing, so we will need to try to come up with more straight-forward names - especially distinguishing well between computational region extent and window extent. I let it as it was for now.)

Next, we need to shorten the top Map Display toolbar to suit the Single-Window mode. But at the same time, we would need to include a new icon for Map Display settings in this toolbar. The solution may be to create a new Navigator toolbar that is vertical and includes all the functions related to navigating a map window.

The design mockup summing up everything (and supposing the Map Scale, Coordinates, Coordinate system options in Map Display settings are checked) could look like this:

mockup2

Other ideas

  • The settings icon settings could be blue to distinguish it from this yellow one, which already exists in GRASS and leads to General settings

  • The icon reload_map_display could be changed to a blue reload_green to make it easier to understand and copy the blue look of the Map Display icons

  • the top Map Display toolbar could even be expanded with some interesting features hidden so far in the Analyze menu button like Measure distance, Measure area..

@lindakarlovska lindakarlovska added enhancement New feature or request GUI wxGUI related labels Dec 14, 2021
@lindakarlovska lindakarlovska added this to the 8.2.0 milestone Dec 14, 2021
@lindakarlovska lindakarlovska self-assigned this Dec 14, 2021
@tmszi
Copy link
Member

tmszi commented Dec 15, 2021

My note on the new reorganization of the widgets on the status bar. From my point of view, it is important to keep Render checkbox widget (Enable/disable auto-rendering) on status bar widget, see additional context in my PR, please.

@petrasovaa
Copy link
Contributor

My note on the new reorganization of the widgets on the status bar. From my point of view, it is important to keep Render checkbox widget (Enable/disable auto-rendering) on status bar widget, see additional context in my PR, please.

I agree Render checkbox should be easily accessible. I wonder if it would make more sense for the single window layout to have one checkbox which would control all map displays at once.

@dnewcomb
Copy link
Contributor

dnewcomb commented Dec 15, 2021 via email

@lindakarlovska
Copy link
Contributor Author

lindakarlovska commented Dec 16, 2021

My note on the new reorganization of the widgets on the status bar. From my point of view, it is important to keep Render checkbox widget (Enable/disable auto-rendering) on status bar widget, see additional context in my PR, please.

I agree Render checkbox should be easily accessible. I wonder if it would make more sense for the single window layout to have one checkbox which would control all map displays at once.

I get your point Tomas why to preserve the Render option in the status bar... but the problem is that we are quite limited by the space here for the Single-Window mode. Maybe we could have just one checkbox as Anna suggests and I would suggest to move it to the main bottom statusbar for the Single-Window mode. There is also the General GUI settings having the option Enable/disable auto-rendering - we need to also think how to cope with that.
Or we could just have the Render check box in Map Display status bar as it is done nowadays and in Map Display settings there could be the check box option Customize statusbar: Show render checkbox .. Maybe there are other ways how to do it, those are just the options that came in my mind. :-)

@landam landam added this to To do in Single Window Layout GUI via automation Dec 16, 2021
@lindakarlovska
Copy link
Contributor Author

lindakarlovska commented Dec 22, 2021

A few days ago, we had a talk (me, @petrasovaa , @wenzeslaus , @landam ) and our discussion above this Issue implied some changes.

Adding and removing new items in the status bar dynamically is quite problematic in terms of implementation. So we have decided to have only one slot in the status bar whose content could be adapted in Map Display Settings. So the Map Display Settings Dialog is planned to look as follows:


Customize map:

  • Enable auto-rendering

  • Show computational extent

  • Align region extent based on display size

  • Constrain display resolution to computational settings

  • Use defined projection

Customize status bar:

  • Show map scale

  • Show coordinates

  • Show window extent

  • Show computational region extent

  • Show display geometry


The Customize map is the same as in the initial proposal. The status bar customization will be enabled through radio buttons (no checkboxes as proposed initially) or one combo box (not decided). But probably radio buttons are better since we can see all possible options at once.

Regarding the Render option - it will be preserved as we know it now. I have also suggested adding the CRS text. We have not decided yet how to incorporate it. It could be either within the individual slot or as the part of the Coordinate widget.
Similarly, we have not decided about merging the Go To item and the Coordinate item. But those things could be figured out later on. We have also decided to move the Mask slot to the Main Window (Layer Manager) status bar.

Project Timeline:

  1. Move checkboxes from combobox to new Map Display settings and create a new Map Display Settings button in the toolbar
  2. Move Mask slot to Main Window status bar
  3. Create status bar customization radio buttons in Map Display settings
  4. ... will be added later

Single Window Layout GUI automation moved this from To do to Done Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related
Projects
No open projects
Development

No branches or pull requests

4 participants