Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GUI should use its own history and not Bash's #962

Closed
wenzeslaus opened this issue Sep 11, 2020 · 2 comments · Fixed by #1917
Closed

[Bug] GUI should use its own history and not Bash's #962

wenzeslaus opened this issue Sep 11, 2020 · 2 comments · Fixed by #1917
Assignees
Labels
bug Something isn't working good first issue Good for newcomers GUI wxGUI related
Projects
Milestone

Comments

@wenzeslaus
Copy link
Member

Describe the bug
Every shell is using its own history file. GUI should do that too, but instead it is using .bash_history file. This does not even work across different platforms or shells, it syncs with Bash, but does not with Z shell or others which now more relevant when macOS switched to Z shell from Bash.

Expected behavior

wxGUI (or the Console specifically) is another "shell", so it should keep history in .wxgui_history.

I'm suggesting wxgui_history over gui_history because of the idea of specific shell (with potentially different features and history records) and over wxgui_console_history because the idea in wxGUI is anyway to run all the user-issued commands through the console.

System description (please complete the following information):

  • Operating System:
    • Windows (no conflict with Bash at this point I guess)
    • Linux with Bash (shared with bash now, will change behavior)
    • macOS with Z shell (no change of behavior, but clarification of files in mapset)

Additional context

See discussion in #930 which triggered this: #930 (comment).

@susi
Copy link
Contributor

susi commented Oct 2, 2021

I'm going to start to look at this :)

@wenzeslaus wenzeslaus modified the milestones: 8.0.0, 8.2.0 Oct 2, 2021
susi added a commit to susi/grass that referenced this issue Oct 2, 2021
@susi susi self-assigned this Oct 2, 2021
@susi susi linked a pull request Oct 3, 2021 that will close this issue
@susi
Copy link
Contributor

susi commented Oct 4, 2021

Should this be targeted for 8.0.0 instead, since we have a PR that fixes it?

Shells automation moved this from To do to Done Oct 5, 2021
wenzeslaus pushed a commit that referenced this issue Oct 5, 2021
wxGUI (or the Console specifically) behaves now as another shell, so it keeps its own history. This creates consistent behavior regardless of the shell used in the terminal.  

Fixes #962.
@wenzeslaus wenzeslaus modified the milestones: 8.2.0, 8.0.0 Nov 12, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this issue Oct 26, 2022
wxGUI (or the Console specifically) behaves now as another shell, so it keeps its own history. This creates consistent behavior regardless of the shell used in the terminal.  

Fixes OSGeo#962.
ninsbl pushed a commit to ninsbl/grass that referenced this issue Feb 17, 2023
wxGUI (or the Console specifically) behaves now as another shell, so it keeps its own history. This creates consistent behavior regardless of the shell used in the terminal.  

Fixes OSGeo#962.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers GUI wxGUI related
Projects
Shells
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants