Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.extension: add '-j' flag which generates JSON file containing the download URLs of the official Addons #1009

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Oct 6, 2020

Add '-j' flag which generates JSON file containing the download URLs of the official Addons independently (needed for Add-Ons build script).

Plus fix find correct Addon URL path.

@neteler
Copy link
Member

neteler commented Oct 10, 2020

I suggest to use -j instead of -p since it is JSON related and not printing anything into the terminal (as it is commonly done with -p.

@tmszi tmszi force-pushed the fix-mkhtml-addons-src-commits-url-build-script branch from e711906 to 6b60462 Compare October 10, 2020 17:47
@tmszi
Copy link
Member Author

tmszi commented Oct 10, 2020

I suggest to use -j instead of -p since it is JSON related and not printing anything into the terminal (as it is commonly done with -p.

I fixed it as suggested in 6b60462.

@tmszi tmszi changed the title g.extension: add '-p' flag which download Add-Ons paths json file g.extension: add '-j' flag which generates JSON file containing the download URLs of the official Addons Oct 10, 2020
@neteler
Copy link
Member

neteler commented Oct 16, 2020

May this PR be merged now?

@tmszi
Copy link
Member Author

tmszi commented Oct 16, 2020

May this PR be merged now?

Yes it can.

@neteler neteler merged commit 4043b2e into OSGeo:master Oct 16, 2020
neteler pushed a commit that referenced this pull request Oct 16, 2020
…ownload URLs of the official Addons (#1009)

* g.extension: rename get Add-Ons paths json file function

* mkhtml: fix get correct Add-On path

* g.extension: fix function arg syntax

* g.extension: add '-j' flag which generates JSON file containing the download URLs of the official Addons
@neteler neteler added this to the 7.8.5 milestone Oct 16, 2020
@tmszi tmszi deleted the fix-mkhtml-addons-src-commits-url-build-script branch October 16, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants