Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warnings, part 4 #1265

Closed
wants to merge 2 commits into from
Closed

Fix compiler warnings, part 4 #1265

wants to merge 2 commits into from

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jan 21, 2021

Fixes compiler warnings:

  • -Wpointer-compare
  • -Wpointer-sign
  • -Wtautological-pointer-compare

Fourth part addressing #1247.

Modules / code parts directly affected:

  • lib/cairodriver
  • lib/db/dbmi_client
  • lib/dspf
  • lib/gis
  • lib/pngdriver
  • lib/raster3d

@nilason nilason mentioned this pull request Jan 21, 2021
Closed
27 tasks
metzm
metzm reviewed Jan 31, 2021
View reviewed changes
lib/raster3d/open.c Outdated Show resolved Hide resolved
metzm
metzm approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, please merge!

@nilason nilason marked this pull request as ready for review February 2, 2021 08:46
@nilason
Copy link
Contributor Author

nilason commented Feb 2, 2021

Updated lib/raster3d/open.c.
Reworded the commit msgs.
Ready for merge.

@metzm
Copy link
Contributor

metzm commented Feb 3, 2021

Updated lib/raster3d/open.c.
Reworded the commit msgs.
Ready for merge.

Please merge.

nilason added a commit that referenced this pull request Feb 4, 2021
@nilason
Fix comparing a pointer to a null character constant (#1265)
f0261d5 
Addresses -Wpointer-compare compiler warnings.
nilason added a commit that referenced this pull request Feb 4, 2021
@nilason
Fix implicit signedness conversion between pointers of integer types (#…
8c8e5bc 
…1265)

Addresses -Wpointer-sign compiler warnings.
@nilason
Copy link
Contributor Author

nilason commented Feb 4, 2021

Cherry picked and pushed manually.

Thanks!

@nilason nilason closed this Feb 4, 2021
@nilason nilason deleted the fix-compiler-warnings-4 branch February 4, 2021 07:45
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
Fix comparing a pointer to a null character constant (OSGeo#1265)
8913c94 
Addresses -Wpointer-compare compiler warnings.
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
@nilason @marisn
Fix implicit signedness conversion between pointers of integer types (O…
b435927 
…SGeo#1265)

Addresses -Wpointer-sign compiler warnings.
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
@ninsbl ninsbl mentioned this pull request Jan 26, 2022
Merged
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
Fix comparing a pointer to a null character constant (OSGeo#1265)
76272ed 
Addresses -Wpointer-compare compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
@nilason @ninsbl
Fix implicit signedness conversion between pointers of integer types (O…
644a8c7 
…SGeo#1265)

Addresses -Wpointer-sign compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
Fix comparing a pointer to a null character constant (OSGeo#1265)
5252d09 
Addresses -Wpointer-compare compiler warnings.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
@nilason @ninsbl
Fix implicit signedness conversion between pointers of integer types (O…
f212d3f 
…SGeo#1265)

Addresses -Wpointer-sign compiler warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metzm metzm metzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilason @metzm @neteler