Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix band references assignment #132

Merged
merged 3 commits into from
Nov 10, 2019
Merged

fix band references assignment #132

merged 3 commits into from
Nov 10, 2019

Conversation

landam
Copy link
Member

@landam landam commented Sep 18, 2019

This PR fixes bug introduced by band reference implementation (#63).

Steps to reproduce

Register vector map into STVDS.

t.register inp=test_v maps=x type=vector start=2010-01-01 --o
Gathering map information...
ERROR: 'VectorDataset' object has no attribute
       'read_band_reference_from_grass'

@landam landam added the bug Something isn't working label Sep 18, 2019
@landam landam requested a review from neteler September 18, 2019 08:07
@landam landam self-assigned this Sep 18, 2019
neteler
neteler requested changes Sep 18, 2019
View reviewed changes
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls accept the wording fix, then it may be merged

landam and others added 2 commits September 18, 2019 14:56
@landam @neteler
Wording
e8dd1ba 
Co-Authored-By: Markus Neteler <neteler@gmail.com>
@landam
add read_band_reference_from_grass()/set_band_reference() also to Abs…
dd6080e 
…tractMapDataset, change register accordigly
@landam
Copy link
Member Author

landam commented Sep 19, 2019

See dd6080e for improvements from OOP design POV. @neteler Please review. Thanks.

@landam
Copy link
Member Author

landam commented Nov 6, 2019

@neteler Please review your review :-)

@landam landam merged commit 04da30d into OSGeo:master Nov 10, 2019
petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
@landam @petrasovaa
fix band references assignment (OSGeo#132)
9a3a687 
* fix register_maps_in_space_time_dataset() for vector type, skip band references assignment

* Wording

Co-Authored-By: Markus Neteler <neteler@gmail.com>

* add read_band_reference_from_grass()/set_band_reference() also to AbstractMapDataset, change register accordigly
landam added a commit to landam/grass that referenced this pull request Jan 28, 2020
@landam
fix band references assignment (OSGeo#132)
f1dfbed 
* fix register_maps_in_space_time_dataset() for vector type, skip band references assignment

* Wording

Co-Authored-By: Markus Neteler <neteler@gmail.com>

* add read_band_reference_from_grass()/set_band_reference() also to AbstractMapDataset, change register accordigly
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neteler neteler neteler approved these changes

Assignees

@landam landam

Labels
bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@landam @neteler