Fix compiler warnings, part 10

[nilason]

Remove argument not used by format string
Fixes -Wformat-extra-args compiler warnings.

This was originally part of #1274, but separated in hope for finding a better solution.

Tenth part addressing #1247.

Compiler warning:

main.c:166:30: warning: data argument not used by format string [-Wformat-extra-args]
                             WEIGHTS[i][j]);
                             ^

[nilason]

I prefer to keep this code active as long as there is a reason to test for if (WEIGHTS[i][j] != -1.0)

Originally posted by @metzm in #1274 (comment)

I think you perhaps misread the code. By design WEIGHTS[i][j] may be -1.0 if map units is used (with -m flag) printed with ......:

grass/raster/r.fill.stats/r.fill.stats.html

Lines 300 to 310 in 4e7606f

	If the distance is given in map units (flag <tt>-m</tt>), then the
	search window can be modeled more accurately as a circle. The
	illustration below shows the precomputed weights for a distance in map
	units that is approximately equivalent to four cells from the center
	cell:
	<pre>
	...... ...... ...... 000.00 000.00 000.00 ...... ...... ......
	...... 000.00 000.02 000.06 000.09 000.06 000.02 000.00 ......
	...... 000.02 000.11 000.22 000.28 000.22 000.11 000.02 ......
	000.00 000.07 000.22 000.44 000.58 000.44 000.22 000.07 000.00

However, that part doesn't affect the troublesome snprintf call and its own if condition.

grass/raster/r.fill.stats/main.c

Lines 159 to 172 in 4e7606f

	if (WEIGHTS[i][j] != -1.0) {
	snprintf(weight_matrix_weight_buf, weight_matrix_line_length,
	"%06.2f ", WEIGHTS[i][j]);
	if (strlen(weight_matrix_weight_buf) >
	(weight_matrix_weight_length)) {
	snprintf(weight_matrix_weight_buf,
	weight_matrix_line_length, "[????] ",
	WEIGHTS[i][j]);
	}
	}
	else {
	snprintf(weight_matrix_weight_buf, weight_matrix_line_length,
	"...... ");
	}

The if condition on line 162-163 can by definition never be true, as the size of weight_matrix_weight_buf is set to weight_matrix_weight_length + 1.

I'm quite confident now this is dead code (L162-167) which can be removed all together. Pushed changes according to this.

[metzm]

The variable weight_matrix_weight_length needs to be removed in a separate PR.

[nilason]

@metzm Thanks!