-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warnings, part 10 #1395
Conversation
The removed 'if' condition was never true and the faulty use of snprintf was never reached.
c9bd1af
to
0623ee3
Compare
Originally posted by @metzm in #1274 (comment) I think you perhaps misread the code. By design grass/raster/r.fill.stats/r.fill.stats.html Lines 300 to 310 in 4e7606f
However, that part doesn't affect the troublesome snprintf call and its own grass/raster/r.fill.stats/main.c Lines 159 to 172 in 4e7606f
The I'm quite confident now this is dead code (L162-167) which can be removed all together. Pushed changes according to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The variable weight_matrix_weight_length
needs to be removed in a separate PR.
@metzm Thanks! |
The removed 'if' condition was never true and the faulty use of snprintf was never reached.
The removed 'if' condition was never true and the faulty use of snprintf was never reached.
The removed 'if' condition was never true and the faulty use of snprintf was never reached.
Remove argument not used by format string
Fixes -Wformat-extra-args compiler warnings.
This was originally part of #1274, but separated in hope for finding a better solution.
Tenth part addressing #1247.
Compiler warning: