Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libproj: added alias for ITRF92 #1460

Merged
merged 1 commit into from
Mar 16, 2021
Merged

libproj: added alias for ITRF92 #1460

merged 1 commit into from
Mar 16, 2021

Conversation

neteler
Copy link
Member

@neteler neteler commented Mar 14, 2021

adds "International_Terrestrial_Reference_Frame_1992" as an alias for ITRF92

Ref: https://lists.osgeo.org/pipermail/grass-user/2021-March/082282.html

adds "International_Terrestrial_Reference_Frame_1992" as an alias for ITRF92

Ref: https://lists.osgeo.org/pipermail/grass-user/2021-March/082282.html
@neteler neteler added this to the 7.8.6 milestone Mar 14, 2021
@neteler neteler requested a review from metzm March 14, 2021 11:56
Copy link
Contributor

@veroandreo veroandreo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the duplication intended?

@@ -1066,6 +1066,8 @@ static const char *papszDatumEquiv[] = {
"Deutsches_Hauptdreiecksnetz",
"South_American_1969",
"South_American_Datum_1969",
"International_Terrestrial_Reference_Frame_1992",
"ITRF92",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ITRF92 was already there it seems. See new line 1072

@neteler
Copy link
Member Author

neteler commented Mar 15, 2021

It is not a duplication. From the description:

The list below is only for files that use a non-standard name for a datum that is already supported in GRASS. The number of entries must be even; they are all in pairs.

So far the "ITRF_1992" alias is resolved as "ITRF92".

This PR adds that the long version "International_Terrestrial_Reference_Frame_1992" is also resolved as "ITRF92".

@veroandreo
Copy link
Contributor

It is not a duplication. From the description:

The list below is only for files that use a non-standard name for a datum that is already supported in GRASS. The number of entries must be even; they are all in pairs.

So far the "ITRF_1992" alias is resolved as "ITRF92".

This PR adds that the long version "International_Terrestrial_Reference_Frame_1992" is also resolved as "ITRF92".

Ah! It's a paired list, got it! Thanks for the explanation! Dismiss the noise please :)

@neteler neteler merged commit b626337 into OSGeo:master Mar 16, 2021
@neteler neteler deleted the proj_alias_ITRF92 branch March 16, 2021 08:07
neteler added a commit that referenced this pull request Mar 16, 2021
adds "International_Terrestrial_Reference_Frame_1992" as an alias for ITRF92

Ref: https://lists.osgeo.org/pipermail/grass-user/2021-March/082282.html
marisn pushed a commit to marisn/grass that referenced this pull request Mar 22, 2021
adds "International_Terrestrial_Reference_Frame_1992" as an alias for ITRF92

Ref: https://lists.osgeo.org/pipermail/grass-user/2021-March/082282.html
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
adds "International_Terrestrial_Reference_Frame_1992" as an alias for ITRF92

Ref: https://lists.osgeo.org/pipermail/grass-user/2021-March/082282.html
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
adds "International_Terrestrial_Reference_Frame_1992" as an alias for ITRF92

Ref: https://lists.osgeo.org/pipermail/grass-user/2021-March/082282.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants