v.random: finished test in reference to #704 #1464
Conversation
1) Checking if number of points equals 100 2) Checking if all points are in the polygon boundary state 3) Checking if all points are in the polygon boundary state
As said in the pull: OSGeo#704
There was a problem hiding this comment.
Thank you for opening a new PR. The history is preserved which is great!
I have some new comments and some same as in #704.
|
@wenzeslaus Please see the updated commit e7429eb |
There was a problem hiding this comment.
Actually, there is still one issue remaining from #704. While at it, add also a author/license comment.
Additionally, please update title and description of this PR to reflect what is being added to GRASS GIS so that these texts can become a commit message. (I will update them as needed before merging, but do your best in expressing that, read something online, see some simple rules here, for example, updating would be misleading when no existing file in GRASS GIS is being updated.) Besides the benefit for the commit history, for PR itself (and any of your future PRs), this make it clear what is being proposed and it makes it easier for people to evaluate if they should look at this and what to review.
SunveerSingh
changed the title
SunveerSingh
changed the title
| """Checking if all points are in the polygon boundary state""" | ||
|
|
||
| def test_restrict(self): |
There was a problem hiding this comment.
Change of syntax is not enough here. This is not documenting the function. See how docstrings for functions work, e.g., here. The result will then make more sense in the terms of formatting (empty lines, Black). Run the code but locally make some modification so that the test fails. You will the see the docstring reported with the failed tests as I mentioned earlier.
|
@wenzeslaus Please see the updated commit. be3120d |
|
Thank you. Merged! For future reference, see the commit message (title/subject/first line and body/description) I used. |
|
Thanks a lot! |
Check number of points, z, polygon boundary. Initially version submitted as OSGeo#704. Co-authored-by: JosefPudil <pepa.pudil@seznam.cz>
Check number of points, z, polygon boundary. Initially version submitted as OSGeo#704. Co-authored-by: JosefPudil <pepa.pudil@seznam.cz>
As said in the pull: #704