wxGUI: Enable all Flake8 warnings #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable remaning Flake8 warnings globally. * More precise (narrow) pattern for scripts and temporal dirs. * Simplify d.rast3d. * Fix some hash-hash comments and long lines. * Ignore remaining warnings using per file ignores. * Break down some directory ignore into true per file ignores for easier fixing and greater current checks.
|
This is outstanding, thanks for your hard work, @wenzeslaus! |
|
Thanks for checking this out @neteler. News would be great, but with highlighting the need for resolving the list(s) of temporary ignores for specific files. Great for new and potential contributors ("good first issue"). The grass pkg (python/grass) still has some warnings enabled globally. |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
* Enable remaning Flake8 warnings globally. * More precise (narrow) pattern for scripts and temporal dirs. * Previously ignored gui/scripts directory is now checked. * Simplify d.rast3d. * Fix some hash-hash comments and long lines. * Ignore remaining warnings using per file ignores. * Break down some directory ignore into true per file ignores for easier fixing and greater current checks.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
* Enable remaning Flake8 warnings globally. * More precise (narrow) pattern for scripts and temporal dirs. * Previously ignored gui/scripts directory is now checked. * Simplify d.rast3d. * Fix some hash-hash comments and long lines. * Ignore remaining warnings using per file ignores. * Break down some directory ignore into true per file ignores for easier fixing and greater current checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and greater current checks.