-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: create parallel wx.frame for Single Window layout development #1604
wxGUI: create parallel wx.frame for Single Window layout development #1604
Conversation
…lus testing rows in wxgui.py
@petrasovaa I would merge it to master (if everything is ok) and then every change against multiple layout will be well visible. I need all dependencies to see anyway so I think it is better to start from something which works. |
That makes sense, please fix first the flake8 issues and make a new directory, let's say 'main_window' and put the file there and this file could be named frame.py. |
@wenzeslaus What if flake and black do not match, which should take precedence? .. |
Which problem are you referring to specifically, I thought the problem with " : " but E203 is already ignored in gui/wxpython/.flake8 |
You need to run
Generally, Black, but you should not be dealing with that unless you need to run flake8 in some special way. |
Vashek, thank you for your explanation! Now it is clear. I added a new directory to the .flake8 file. |
gui/wxpython/.flake8
Outdated
@@ -44,6 +44,7 @@ per-file-ignores = | |||
iscatt/*: F841, E722, E741, F405, F403, E501 | |||
lmgr/giface.py: E501, E741 | |||
lmgr/frame.py: F841, E722, W605, E501 | |||
main_window/frame.py: F841, E722, W605, E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please fix these instead of ignoring them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. :-)
…SGeo#1604) The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
…SGeo#1604) The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
* develop: wxGUI: create parallel wx.frame for Single Window layout development (OSGeo#1604)
…SGeo#1604) The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
…SGeo#1604) The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
This PR serves for preparing a coding environment for building a separate Single Window application. It creates a copy of GMFrame which is ready for adapting and developing a new Single Window Layout solution through Google Summer of Code.