Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: create parallel wx.frame for Single Window layout development #1604

Conversation

lindakarlovska
Copy link
Contributor

@lindakarlovska lindakarlovska commented May 30, 2021

This PR serves for preparing a coding environment for building a separate Single Window application. It creates a copy of GMFrame which is ready for adapting and developing a new Single Window Layout solution through Google Summer of Code.

@lindakarlovska lindakarlovska added GUI wxGUI related gsoc Reserved for Google Summer of Code student(s) labels May 30, 2021
@petrasovaa petrasovaa marked this pull request as draft May 31, 2021 02:52
@lindakarlovska
Copy link
Contributor Author

lindakarlovska commented May 31, 2021

This PR serves for preparing a coding environment for building a separate Single Window application. It creates a copy of GMFrame called SingleWindowFrame which is ready for adapting and developing a new Single Window Layout solution through Google Summer of Code.

@petrasovaa I would merge it to master (if everything is ok) and then every change against multiple layout will be well visible. I need all dependencies to see anyway so I think it is better to start from something which works.
I could make an entirely blank file and start really from the scratch but this approach makes more sense, at least for me, what's your opinion?

@petrasovaa
Copy link
Contributor

This PR serves for preparing a coding environment for building a separate Single Window application. It creates a copy of GMFrame called SingleWindowFrame which is ready for adapting and developing a new Single Window Layout solution through Google Summer of Code.

@petrasovaa I would merge it to master (if everything is ok) and then every change against multiple layout will be well visible. I need all dependencies to see anyway so I think it is better to start from something which works.
I could make an entirely blank file and start really from the scratch but this approach makes more sense, at least for me, what's your opinion?

That makes sense, please fix first the flake8 issues and make a new directory, let's say 'main_window' and put the file there and this file could be named frame.py.

@lindakarlovska
Copy link
Contributor Author

lindakarlovska commented Jun 1, 2021

This PR serves for preparing a coding environment for building a separate Single Window application. It creates a copy of GMFrame called SingleWindowFrame which is ready for adapting and developing a new Single Window Layout solution through Google Summer of Code.

@petrasovaa I would merge it to master (if everything is ok) and then every change against multiple layout will be well visible. I need all dependencies to see anyway so I think it is better to start from something which works.
I could make an entirely blank file and start really from the scratch but this approach makes more sense, at least for me, what's your opinion?

That makes sense, please fix first the flake8 issues and make a new directory, let's say 'main_window' and put the file there and this file could be named frame.py.

@wenzeslaus What if flake and black do not match, which should take precedence? ..

@petrasovaa
Copy link
Contributor

petrasovaa commented Jun 1, 2021

@wenzeslaus What if flake and black do not match, which should take precedence? ..

Which problem are you referring to specifically, I thought the problem with " : " but E203 is already ignored in gui/wxpython/.flake8
See also this.

@wenzeslaus
Copy link
Member

I thought the problem with " : " but E203 is already ignored in gui/wxpython/.flake8

You need to run flake8 from the gui/wxpython/ dir in order for the config file to be picked up automatically. When in doubt about the local setup, see results in the CI which is (supposed to be) set the right way.

What if flake and black do not match, which should take precedence?

Generally, Black, but you should not be dealing with that unless you need to run flake8 in some special way.

@lindakarlovska
Copy link
Contributor Author

lindakarlovska commented Jun 2, 2021

I thought the problem with " : " but E203 is already ignored in gui/wxpython/.flake8

You need to run flake8 from the gui/wxpython/ dir in order for the config file to be picked up automatically. When in doubt about the local setup, see results in the CI which is (supposed to be) set the right way.

What if flake and black do not match, which should take precedence?

Generally, Black, but you should not be dealing with that unless you need to run flake8 in some special way.

Vashek, thank you for your explanation! Now it is clear. I added a new directory to the .flake8 file.

@lindakarlovska lindakarlovska marked this pull request as ready for review June 2, 2021 07:54
@lindakarlovska lindakarlovska marked this pull request as draft June 2, 2021 10:27
@lindakarlovska lindakarlovska marked this pull request as ready for review June 2, 2021 10:33
@@ -44,6 +44,7 @@ per-file-ignores =
iscatt/*: F841, E722, E741, F405, F403, E501
lmgr/giface.py: E501, E741
lmgr/frame.py: F841, E722, W605, E501
main_window/frame.py: F841, E722, W605, E501
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix these instead of ignoring them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. :-)

@petrasovaa petrasovaa merged commit 151e0a6 into OSGeo:master Jun 4, 2021
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 4, 2021
…SGeo#1604)

The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 4, 2021
…SGeo#1604)

The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 4, 2021
* develop:
  wxGUI: create parallel wx.frame for Single Window layout development (OSGeo#1604)
@wenzeslaus wenzeslaus added this to In progress in Single Window Layout GUI via automation Jun 9, 2021
@wenzeslaus wenzeslaus moved this from In progress to Done in Single Window Layout GUI Jun 9, 2021
@neteler neteler added this to the 8.0.0 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
…SGeo#1604)

The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
…SGeo#1604)

The copy of frame.py prepared for developing single layout solution plus testing rows in wxgui.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Reserved for Google Summer of Code student(s) GUI wxGUI related
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants