copy libs into bin directory after running make distclean

[landam]

package.sh copies selected libs into bin directory. Than make distclean is run (this command removes bin directory). As result ongoing compilation can fail due to wrong libs in the path:

if [ "/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/bin/d.barscale.exe"
!= "" ] ; then GISRC=/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/demolocation/.grassrc78
GISBASE=C:/msys64/usr/src/grass78/dist.x86_64-w64-mingw32
PATH="/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/bin:/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/bin:/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/scripts:$PATH"
PYTHONPATH="C:/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/etc/python;C:/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/gui/wxpython;$PYTHONPATH"
PATH="/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/bin:/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/bin:/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/scripts:/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/lib:/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/lib:/mingw64/lib/ccache/bin:/C//OS3944~1/apps/Python37:/C//OS3944~1/apps/Python37/Scripts:/C/OS3944~1/bin:/C/Windows/system32:/C/Windows:/C/Windows/system32/WBem:/C/msys64/usr/bin:/C/msys64/mingw64/bin/:/C/msys64/usr/src/grass78/mswindows/osgeo4w/lib:/C/msys64/usr/src/grass78/mswindows/osgeo4w:/C/windows32/system32:/C/windows:/C/windows32/system32:/C/windows:/usr/bin:/mingw64/bin/:/c/msys64/usr/src/grass78/mswindows/osgeo4w/lib:/c/msys64/usr/src/grass78/mswindows/osgeo4w:/c/windows32/system32:/c/windows:/c/windows32/system32:/c/windows"
LC_ALL=C LANG=C LANGUAGE=C
/c/msys64/usr/src/grass78/dist.x86_64-w64-mingw32/bin/d.barscale.exe
--html-description < /dev/null | grep -v '</body>\|</html>' >
d.barscale.tmp.html ; fi
make[3]: *** [../../include/Make/Html.make:14: d.barscale.tmp.html] Error 1

[hellik]

Can't test the PR at the moment.

at least compiling works here on my side without this PR.

[landam]

Can't test the PR at the moment.

at least compiling works here on my side without this PR.

This PR shouldn't affect your compilation. Anyway will wait for your review. The fact that your compilation works without this PR is strange. PATH contains osgeo4w before msys2. It means that zlib1.dll from osgeo4w is used when running eg. d.barscale which causing failure.

[landam]

Meanwhile I can start producing daily builds with local patch.

[hellik]

Meanwhile I can start producing daily builds with local patch.

yes please start! thanks

[hellik]

you PR locally applied:

hkmyr@DESKTOP-VADT8Q4 MINGW64 /usr/src/test_landam/grass_master
$ git branch -a
* landam-wingrass_copy_libs_fix
  master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/releasebranch_7_0
  remotes/origin/releasebranch_7_2
  remotes/origin/releasebranch_7_4
  remotes/origin/releasebranch_7_6
  remotes/origin/releasebranch_7_8

GRASS is now configured for:  x86_64-w64-mingw32

  Source directory:           /usr/src/test_landam/grass_master
  Build directory:            /usr/src/test_landam/grass_master
  Installation directory:     ${prefix}/grass79
  Startup script in directory:/c/OSGeo4W64/bin
  C compiler:                 gcc -g -O2 
  C++ compiler:               c++ -g -O2
  Building shared libraries:  yes
  OpenGL platform:            Windows

  MacOSX application:         no
  MacOSX architectures:       
  MacOSX SDK:                 

  BLAS support:               no
  BZIP2 support:              yes
  C++ support:                yes
  Cairo support:              yes
  DWG support:                no
  FFTW support:               yes
  FreeType support:           yes
  GDAL support:               yes
  GEOS support:               yes
  LAPACK support:             no
  Large File support (LFS):   yes
  libLAS support:             yes
  MySQL support:              no
  NetCDF support:             no
  NLS support:                yes
  ODBC support:               yes
  OGR support:                yes
  OpenCL support:             no
  OpenGL support:             yes
  OpenMP support:             no
  PDAL support:               no
  PNG support:                yes
  POSIX thread support:       no
  PostgreSQL support:         yes
  Readline support:           no
  Regex support:              yes
  SQLite support:             yes
  TIFF support:               yes
  X11 support:                no
  Zstandard support:          yes

  using new PROJ 5+ API

configure is working, compilation starts; lets wait if compilation is finishing

[hellik]

GRASS GIS 7.9.dev 330521111 compilation log
--------------------------------------------------
Started compilation: Mon Nov  4 18:50:42 CET 2019
--
Errors in:
No errors detected.
--
Finished compilation: Mon Nov  4 19:29:46 CET 2019