Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/vdigit: fix double click on the line/boundary after activate 'Move selected vertex' editing tool and then switch to 'Edit selected line/boundary' editing tool #1815

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Aug 23, 2021

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI Vector Digitizer: g.gui.vdigit -c test
  2. Draw some line
  3. Activate 'Move selected vertex' editing tool
  4. Double left click on the line
  5. Activate (switch to) 'Edit selected line/boundary' editing tool
  6. You get error message

Error message

Traceback (most recent call last):
  File "/usr/lib64/grass79/gui/wxpython/mapwin/buffered.py", line 1430, in MouseActions
    self.OnMouseMoving(event)
  File "/usr/lib64/grass79/gui/wxpython/mapwin/buffered.py", line 1703, in OnMouseMoving
    self._onMouseMoving(event)
  File "/usr/lib64/grass79/gui/wxpython/vdigit/mapwindow.py", line 1246, in _onMouseMoving
    pdc=self.pdcTmp, begin=self.Cell2Pixel(self.polycoords[-1])
IndexError: list index out of range

Expected behavior

No error message after double-clicking on the line/boundary, after activate the 'Move selected vertex' editing tool and then activate (switch to) 'Edit selected line/boundary' editing tool.

…ove selected vertex' editing tool and switch to 'Edit selected line/boundary' editing tool
@tmszi tmszi added bug Something isn't working backport_needed GUI wxGUI related labels Aug 23, 2021
@tmszi tmszi merged commit 99b1825 into OSGeo:main Aug 26, 2021
tmszi added a commit to tmszi/grass that referenced this pull request Aug 26, 2021
…ove selected vertex' editing tool and switch to 'Edit selected line/boundary' editing tool (OSGeo#1815)
@tmszi tmszi deleted the wxgui-vdigit-fix-move-vertex-double-click branch August 26, 2021 05:29
@neteler neteler added this to the 7.8.6 milestone Dec 9, 2021
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
…ove selected vertex' editing tool and switch to 'Edit selected line/boundary' editing tool (OSGeo#1815)
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
…ove selected vertex' editing tool and switch to 'Edit selected line/boundary' editing tool (OSGeo#1815)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants