Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI: do not fail on invalid RC file (empty) #185

Merged
merged 1 commit into from
Nov 15, 2019
Merged

GUI: do not fail on invalid RC file (empty) #185

merged 1 commit into from
Nov 15, 2019

Conversation

landam
Copy link
Member

@landam landam commented Nov 8, 2019

Currently GUI startup screen is not shown on invalid RC file (eg. only one empty line, this situation can happen, recognized especially on Windows platform).

Starting GRASS GIS...
WARNING: Invalid line in RC file (/tmp/grass7-martin-18299/gisrc): '
' (not enough values to unpack (expected 2, got 1))

WARNING: Empty RC file (/tmp/grass7-martin-18299/gisrc)

ERROR: Error in GUI startup. See messages above (if any) and if necessary, please report this error to the GRASS developers.
On systems with package manager, make sure you have the right GUI package, probably named grass-gui, installed.
To run GRASS GIS in text mode use the --text flag.
Use '--help' for further options
     grass79 --help
See also: https://grass.osgeo.org/grass79/manuals/helptext.html
Exiting...

This PR allow showing GUI startup screen. So the user can more easily recover the session.

@landam landam self-assigned this Nov 8, 2019
@landam landam added bug Something isn't working windows Microsoft Windows specific labels Nov 8, 2019
@landam landam merged commit 3ed443f into OSGeo:master Nov 15, 2019
@landam landam deleted the empty-rc-fix branch November 15, 2019 21:37
landam added a commit that referenced this pull request Nov 15, 2019
@landam
GUI: do not fail on invalid RC file (empty) (#185)
fedff42
@neteler
Copy link
Member

neteler commented Nov 15, 2019

Backported to relbranch78 in fedff42

(I wonder if this could be auto-referenced somehow!)

petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
@landam @petrasovaa
GUI: do not fail on invalid RC file (empty) (OSGeo#185)
47ce840
landam added a commit to landam/grass that referenced this pull request Jan 28, 2020
@landam
GUI: do not fail on invalid RC file (empty) (OSGeo#185)
b6906ed
@neteler neteler added this to the 7.8.2 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@landam landam

Labels
bug Something isn't working windows Microsoft Windows specific
Projects
None yet
Milestone
7.8.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@landam @neteler