-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
startup: Use universal newlines #1952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.split(os.linesep)
-> .splitlines()
makes sense. The other change is not needed. Resolving the merge conflict with fully accepting the change on main, ignoring changes here should resolves the issue because it is resolved in the main branch using JSON.
@HuidaeCho shall we move the milestone to 8.0.1? |
Resolved; Dismissing review to merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...I (would) approve :-)
* startup: Use universal newlines * wx is opened in universal newlines mode; juse use \n * Remove %s
Backport done |
* startup: Use universal newlines * wx is opened in universal newlines mode; juse use \n * Remove %s
* startup: Use universal newlines * wx is opened in universal newlines mode; juse use \n * Remove %s
* startup: Use universal newlines * wx is opened in universal newlines mode; juse use \n * Remove %s
str.split(os.linesep)
doesn't work in Windows when a file is open in text mode. Use str.splitlines().