Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/mkhtml.py: fix module/official addons source code and history URL branch #2038

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Dec 26, 2021

Describe the bug
Module (compilation), official addon which is installed from the local directory have incorrect manual page source code and history URL, which URL path don't match GRASS GIS release branch name.

To Reproduce
Steps to reproduce the behavior:

Module:

  1. Install GRASS GIS 7.8 release version
  2. Check some module manual page source code and history URL e.g. v.surf.rst cat /usr/lib64/grass78/docs/html/v.surf.rst.html
<p>
<i>Last changed: $Date$</i>
--><h2>SOURCE CODE</h2>
<p>Available at: <a href="https://github.com/OSGeo/grass/tree/master/vector/v.surf.rst">v.surf.rst source code</a> (<a href="https://github.com/OSGeo/grass/commits/master/vector/v.surf.rst">history</a>)</p>
<hr class="header">
<p>

Addon:

  1. Install GRASS 7.8 release version with this PR applied
  2. Download some addon only e.g. g.extension -d wx.metadata
  3. Install downloaded addon from the local directory g.extension wx.metadata url=/tmp/grass7-tomas-25558/tmpi9syivf2/wx.metadata
  4. Check installed addon manual page source code and history URL e.g. g.gui.cswbrowser.html cat .grass7/addons/docs/html/g.gui.cswbrowser.html

Expected behavior
Module, official addon which is installed from the local directory should be have correct manual page source code and history URL which match GRASS GIS release.

System description:

  • GRASS GIS version: releasebranch_7_8

@tmszi tmszi added the bug Something isn't working label Dec 26, 2021
@tmszi tmszi requested a review from neteler December 26, 2021 20:10
@tmszi tmszi added this to the 7.8.7 milestone Dec 26, 2021
tools/mkhtml.py Outdated Show resolved Hide resolved
Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@tmszi tmszi force-pushed the fix-mkhtml-module-src-hist-url-branch-rel78 branch from d4a4c54 to 3ced08a Compare December 27, 2021 17:48
@tmszi
Copy link
Member Author

tmszi commented Dec 27, 2021

3ced08a rebase.

@tmszi
Copy link
Member Author

tmszi commented Dec 27, 2021

@neteler I'm using in Python code f-string, which is available with version >= 3.6, but I can't find what is the minimum version of Python needed for GRASS GIS (7.8/8.0) to work.

@tmszi
Copy link
Member Author

tmszi commented Dec 27, 2021

@neteler I'm using in Python code f-string, which is available with version >= 3.6, but I can't find what is the minimum version of Python needed for GRASS GIS (7.8/8.0) to work.

7.8 minimal Python version
8.0 minimal Python version

@neteler
Copy link
Member

neteler commented Dec 27, 2021

This is still subject to discussion: https://trac.osgeo.org/grass/wiki/RFC/8_LanguageStandardsSupportPython

I assume that Python 3.6+ is fine.

@tmszi tmszi merged commit 8ce450d into OSGeo:releasebranch_7_8 Dec 27, 2021
@tmszi tmszi deleted the fix-mkhtml-module-src-hist-url-branch-rel78 branch December 27, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants