Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.list, t.rast.list: fix missing band_reference #206

Merged
merged 1 commit into from Nov 25, 2019
Merged

t.list, t.rast.list: fix missing band_reference #206

merged 1 commit into from Nov 25, 2019

Conversation

neteler
Copy link
Member

@neteler neteler commented Nov 22, 2019

This enables output like this:

t.rast.list openeo_bolzano_S2 columns=name,band_reference,start_time
name|band_reference|start_time
T32TPS_20180606T102019_B01|S2_1|2018-06-06 10:25:12.692000
T32TPS_20180606T102019_B02|S2_2|2018-06-06 10:25:12.692000
T32TPS_20180606T102019_B03|S2_3|2018-06-06 10:25:12.692000
T32TPS_20180606T102019_B04|S2_4|2018-06-06 10:25:12.692000
...

@neteler neteler added the bug Something isn't working label Nov 22, 2019
@neteler
Copy link
Member Author

neteler commented Nov 22, 2019

Probably we should also change the default output from

#% answer: name,mapset,start_time,end_time

to

#% answer: name,band_reference,mapset,start_time,end_time

?

@veroandreo
Copy link
Contributor

Probably we should also change the default output from

#% answer: name,mapset,start_time,end_time

to

#% answer: name,band_reference,mapset,start_time,end_time

?

I'm not sure about this.

In my experience, the cases in which products other than satellite images with all bands are registered as time series are more frequent. So, if we change the default, in most cases the report will have an extra column full of 'None'. I'd prefer to keep the default as is.

@neteler
Copy link
Member Author

neteler commented Nov 25, 2019

In my experience, the cases in which products other than satellite images with all bands are registered as time series are more frequent. So, if we change the default, in most cases the report will have an extra column full of 'None'. I'd prefer to keep the default as is.

... ok, makes sense.

@neteler neteler merged commit 5b87a33 into OSGeo:master Nov 25, 2019
@neteler neteler deleted the temporal_fix_band_reference branch November 26, 2019 14:18
petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Dec 3, 2019
landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
@neteler neteler added this to the 7.8.2 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants