Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkhtml: Generate local JSON file with core modules and their last commit #2140
mkhtml: Generate local JSON file with core modules and their last commit #2140
Changes from 7 commits
db79c1c
1137a32
f62abb0
d60c66e
3ae3a82
28047cf
fc46089
7216e8f
36fbec3
75e35bb
98483b6
0ffd81d
3f61f88
9ff2a65
82e7b3c
de8157e
53d6276
d2e88c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to limit that to HTML files? We are interested in history of the whole directory, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a directory filter that filters directories that are not core modules based on the assumption that each core module has a manual page in the root directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see, f is not used to get the path. Can you rewrite the code so that the operation on the whole directory is not a inside of a loop over files and add comments? Perhaps something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole "can't import grass.script therefore I'm compiling" is shaky, but perhaps good enough for this PR.