Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: Fix -Wunused-lambda-capture compiler warning #2160

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Feb 4, 2022

As reported in #2156.

Affects:

  • v.in.pdal

@nilason nilason mentioned this pull request Feb 4, 2022
21 tasks
@nilason nilason added this to the 8.2.0 milestone Feb 4, 2022
@nilason nilason added C++ Related code is in C++ enhancement New feature or request labels Feb 4, 2022
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm the author of the original code and I think that my idea was that category number needs to be checked. (There can be much more points than we can have categories in a vector map, so we should tell the user when this issue arises and categories are being assigned. I think there is similar code in v.in.lidar.)

Adding a todo here or opening an issue is probably appropriate.

@nilason
Copy link
Contributor Author

nilason commented Feb 9, 2022

I'm the author of the original code and I think that my idea was that category number needs to be checked. (There can be much more points than we can have categories in a vector map, so we should tell the user when this issue arises and categories are being assigned. I think there is similar code in v.in.lidar.)

Adding a todo here or opening an issue is probably appropriate.

Ok, I’ll comment it out and add a TODO, leave it to you to open an issue.

@nilason
Copy link
Contributor Author

nilason commented Feb 14, 2022

Now added TODO comment.

@nilason nilason merged commit e9f304b into OSGeo:main Mar 2, 2022
@nilason nilason deleted the fix_wall_warnings_04 branch March 18, 2022 16:11
@wenzeslaus wenzeslaus changed the title Fix -Wunused-lambda-capture compiler warning checks: Fix -Wunused-lambda-capture compiler warning Apr 27, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
Commented out unused variable, as work TODO:
reported in OSGeo#2234.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Commented out unused variable, as work TODO:
reported in OSGeo#2234.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Commented out unused variable, as work TODO:
reported in OSGeo#2234.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ Related code is in C++ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants