Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI Single-Window: Make Tools pane wider after startup #2216

Conversation

lindakladivova
Copy link
Contributor

@lindakladivova lindakladivova commented Feb 16, 2022

Before:
Screenshot from 2022-02-17 01-21-45

After:
Screenshot from 2022-02-17 01-18-37
The width is the same for both side panels.

@lindakladivova lindakladivova added the GUI wxGUI related label Feb 16, 2022
@lindakladivova lindakladivova marked this pull request as draft February 16, 2022 16:09
@lindakladivova lindakladivova added the enhancement New feature or request label Feb 16, 2022
@lindakladivova lindakladivova added this to the 8.0.2 milestone Feb 16, 2022
@lindakladivova lindakladivova marked this pull request as ready for review February 17, 2022 08:03
@petrasovaa
Copy link
Contributor

What about #2210, could you try to address it here? It seems related.

@lindakladivova
Copy link
Contributor Author

lindakladivova commented Feb 18, 2022

What about #2210, could you try to address it here? It seems related.

Well, I have already kind of addressed it (without noticing @veroandreo 's Issue, good to see it now).
The min pane width is set up to the one fifth of display size , here I suggest one sixth. I am not sure if to go even further and allow to shrink it more - the pane can be minimized if needed.

I also looked at the small arrow which appears in Data Catalog toolbar when shrinked "too much". I remember that the arrow was not appearing but I think that the problem was in Search box. Now when Search box is no longer the part of toolbar, it fixed itself.

@veroandreo veroandreo modified the milestones: 8.0.2, 8.2.0 Feb 18, 2022
@veroandreo
Copy link
Contributor

I changed milestone to 8.2 as this lives only in main so far, right?

@petrasovaa
Copy link
Contributor

@veroandreo does this address #2210? I am thinking they could be shrinked even more, but no strong opinion.

@lindakladivova
Copy link
Contributor Author

I changed milestone to 8.2 as this lives only in main so far, right?

Oh sure, the previous plan :-) I switched 0 and 2 by mistake.

@lindakladivova
Copy link
Contributor Author

@veroandreo does this address #2210? I am thinking they could be shrinked even more, but no strong opinion.

I have tried one eighth of display size as a minimum pane size. It looks as follows:
Screenshot from 2022-02-20 07-22-29

probably better, I would go with this. What do you think?

@veroandreo
Copy link
Contributor

@veroandreo does this address #2210? I am thinking they could be shrinked even more, but no strong opinion.

I have tried one eighth of display size as a minimum pane size. It looks as follows: Screenshot from 2022-02-20 07-22-29

probably better, I would go with this. What do you think?

Yes! I like this one better! For more space, as you said earlier, the user can directly minimize.

@lindakladivova
Copy link
Contributor Author

Before: Screenshot from 2022-02-17 01-21-45

After: Screenshot from 2022-02-17 01-18-37 The width is the same for both side panels.

And the right panel could be probably a bit narrower for the startup. What do you think?
Screenshot from 2022-02-20 08-00-12
I first thought that the initial pane sizes should be the same on both sides but there is an empty space on the right then...

@veroandreo
Copy link
Contributor

And the right panel could be probably a bit narrower for the startup. What do you think? Screenshot from 2022-02-20 08-00-12 I first thought that the initial pane sizes should be the same on both sides but there is an empty space on the right then...

It looks good to me, yes. Esp. since the focus of the right panel at startup is on the Tools tab. Then, it can be resized when there's an output in the Console tab or if the user wants to use the Python terminal tab.

@petrasovaa
Copy link
Contributor

This doesn't seem to differ a lot from the original state. I would make the right pane wider because often one of the first things I do is to resize it. Also when I tested it looks like the right pane doesn't have a minimal width, while the left does, was that the intention? I don't have a strong opinion whether they should be both the same width, although I think it would make things simpler. Ultimately I think the layout should be saved in settings (out of scope of this PR).

@lindakladivova
Copy link
Contributor Author

lindakladivova commented Feb 24, 2022

This doesn't seem to differ a lot from the original state. I would make the right pane wider because often one of the first things I do is to resize it. Also when I tested it looks like the right pane doesn't have a minimal width, while the left does, was that the intention? I don't have a strong opinion whether they should be both the same width, although I think it would make things simpler. Ultimately I think the layout should be saved in settings (out of scope of this PR).

We can make the size of both panes the same, I do not have a strong opinion either. The minimum size could be also set up. There is just a little problem that you actually set up the minimum size only for this particular "startup" notebook but when a user creates a different notebook the minimum size is not applied.

@petrasovaa petrasovaa linked an issue Feb 25, 2022 that may be closed by this pull request
@petrasovaa petrasovaa merged commit 486b2fe into OSGeo:main Feb 25, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Allow to shrink Data Catalog pane in the Single-window GUI
3 participants