Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: fix help string config options #2240

Merged
merged 2 commits into from Mar 1, 2022

Conversation

petrasovaa
Copy link
Contributor

Add python_path and remove svn_revision as obsolete.

Add python_path and remove svn_revision as obsolete.
@petrasovaa petrasovaa added this to the 8.2.0 milestone Feb 28, 2022
@neteler
Copy link
Member

neteler commented Feb 28, 2022

Isn't also a change here needed?

elif arg == "svn_revision":

and while at it, probably also here (the only other places with svn_revision)?:

python/grass/gunittest/multireport.py
38:        self.svn_revision = None
410:                "<td>{result.svn_revision}</td>"
500:            result.svn_revision = str(summary["svn_revision"])
559:        # x = [result.svn_revision for result in results]
561:            result.timestamp.strftime("%Y-%m-%d") + " (r" + result.svn_revision + ")"

python/grass/gunittest/reporters.py
163:def get_svn_revision():
874:            svn_revision = ""
876:            svn_revision = svn_info["revision"]
905:        summary["svn_revision"] = svn_revision

Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are just adding missing doc for python_path, please remove the unrelated svn_revision change. This will speed up the merge of the python_path change.

@petrasovaa petrasovaa merged commit 4548327 into OSGeo:main Mar 1, 2022
@petrasovaa petrasovaa deleted the fix-grass-init-doc branch March 1, 2022 17:49
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants