-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grass.jupyter: Update __init__.py
to only necessary modules
#2312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but:
These modules are not for direct by users of grass.jupyter. They are imported by other modules as needed.
There are also functions or classes here and there which are internal, no? I think it would be best to avoid the start imports and import whatever we think should be here. (That's at least one technique how to do that.)
This will also shorted the API documentation page to only include modules intended for usage.
This would be great. However, I don't see that in the output, for example reprojection_renderer (I'm looking at the Sphinx doc artifact generated by the Pylint workflow). This is PR still worth doing even without this part.
Changed to include only public API objects. Notebooks work for me. |
__init__.py
to only necessary modules
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
These modules are not for direct by users of grass.jupyter. They are imported by other modules as needed. This will also shorted the API documentation page to only include modules intended for usage.