modules: Always use current major version in VTK outputs (r.out.vtk, r3.out.vtk, v.out.vtk) #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenzeslaus
force-pushed
the
no-major-version-in-vtk
branch
from
9e1096f
to
461beca
Compare
|
This removes outdated references to v7 from the generated VTK files. With this PR, no further updates will be needed because the version is simply not there. This is similar to #2342. The any mention of the version is removed completely, so the question is if it is okay. |
|
Now the current major version is obtained. Given that the header line should describe the data, title might be actually more appropriate. Full version number could be used too, but similarly to #2342, it would be a change in output, so perhaps a topic for a separate PR. The existing test is now enabled and the values updated. The test will need an update for the next major version. |
wenzeslaus
changed the title
wenzeslaus
force-pushed
the
no-major-version-in-vtk
branch
from
71f613f
to
5348f37
Compare
…, v.out.vtk) r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line. This removes the major version from the string.
wenzeslaus
force-pushed
the
no-major-version-in-vtk
branch
from
5348f37
to
f8db520
Compare
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
…r3.out.vtk, v.out.vtk) (OSGeo#2343) r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line for the 'exported from' description text. This removes the hard-coded major version from the string and uses the current major version instead.
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
…r3.out.vtk, v.out.vtk) (OSGeo#2343) r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line for the 'exported from' description text. This removes the hard-coded major version from the string and uses the current major version instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r.out.vtk, r3.out.vtk, and v.out.vtk include software name in the VTK header line for the 'exported from' description text. This removes the hard-coded major version from the string and uses the current major version instead.
Reference data need update too and will need updates in the future. However, the test will fail and show the need to update, so it should be clear.