Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.vi: write out FCELL instead of DCELL #236

Merged
merged 1 commit into from Dec 3, 2019
Merged

i.vi: write out FCELL instead of DCELL #236

merged 1 commit into from Dec 3, 2019

Conversation

neteler
Copy link
Member

@neteler neteler commented Dec 3, 2019

To avoid overly large raster maps, this PR changes DCELL output to FCELL precision which appears to be enough for vegetation indices.

All tests pass with python3 test_vi.py

To avoid overly large raster maps, this PR changes DCELL output to FCELL precision which appears to be enough for vegetation indices.

All tests pass with `python3 test_vi.py`
@neteler neteler requested review from ninsbl and metzm December 3, 2019 16:24
Copy link
Contributor

@metzm metzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCELL instead of DCELL makes sense for these indices, the changes look good to me.

@neteler neteler merged commit 7c05b44 into OSGeo:master Dec 3, 2019
@neteler neteler deleted the i_vi_use_FCELL_not_DCELL branch December 3, 2019 22:04
neteler added a commit that referenced this pull request Dec 12, 2019
To avoid overly large raster maps, this PR changes DCELL output to FCELL precision which appears to be enough for vegetation indices.

All tests pass with `python3 testsuite/test_vi.py`
landam pushed a commit to landam/grass that referenced this pull request Jan 28, 2020
To avoid overly large raster maps, this PR changes DCELL output to FCELL precision which appears to be enough for vegetation indices.

All tests pass with `python3 testsuite/test_vi.py`
petrasovaa pushed a commit to petrasovaa/grass that referenced this pull request Feb 18, 2020
To avoid overly large raster maps, this PR changes DCELL output to FCELL precision which appears to be enough for vegetation indices.

All tests pass with `python3 testsuite/test_vi.py`
@neteler neteler added this to the 7.8.3 milestone Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants