v.surf.idw: fix applying mask #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrasovaa
added
bug
wenzeslaus
approved these changes
May 19, 2022
There was a problem hiding this comment.
This looks good. The right test for "is cell masked out" according to lib/raster/get_row.c is
mask_row_buffer[i] == 0 || Rast_is_c_null_value(&mask_row_buffer[i])
so exactly what the new code does.
The code uses Rast_get_c_row while Rast_get_c_row_nomask might be more appropriate for reading mask and more aligned with the internal code for applying mask and perhaps little faster, too, since there is no masking step. As far as I understand, using Rast_get_c_row makes the mask[col] == 0 part of the test useless because zeros were already converted to nulls in Rast_get_c_row. When Rast_get_c_row_nomask is used, mask[col] == 0 is appropriate because that's the correct masking method.
petrasovaa
added a commit
that referenced
this pull request
May 20, 2022
petrasovaa
added a commit
that referenced
this pull request
May 20, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Oct 26, 2022
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v.surf.idw doesn't apply mask properly, it works only when the mask has value 0, not null. So when you create mask with r.mask, v.surf.idw ignores that and interpolates for those values as well.
See also https://trac.osgeo.org/grass/ticket/3677 (not sure why I couldn't reproduce it there.)