Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

g.extension: Add details to URL error message #2479

Merged

Conversation

wenzeslaus
Copy link
Member

The URL validation introduced in 45ff0ea does not include the original error message details in the user-visible error message. This adds the details and also fixes the formatting which was done on the regular string literal instead of the translated string.

The URL validation introduced in 45ff0ea does not include the original error message details in the user-visible error message. This adds the details and also fixes the formatting which was done on the regular string literal instead of the translated string.
@wenzeslaus wenzeslaus requested a review from ninsbl July 12, 2022 21:18
@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Jul 25, 2022
@wenzeslaus wenzeslaus added enhancement New feature or request Python Related code is in Python labels Jul 26, 2022
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wenzeslaus wenzeslaus merged commit c0a83a3 into OSGeo:main Aug 1, 2022
@wenzeslaus wenzeslaus deleted the show-error-message-in-g.extension branch August 1, 2022 12:37
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Oct 26, 2022
The URL validation introduced in 45ff0ea does not include the original error message details in the user-visible error message. This adds the details and also fixes the formatting which was done on the regular string literal instead of the translated string.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
The URL validation introduced in 45ff0ea does not include the original error message details in the user-visible error message. This adds the details and also fixes the formatting which was done on the regular string literal instead of the translated string.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
The URL validation introduced in 45ff0ea does not include the original error message details in the user-visible error message. This adds the details and also fixes the formatting which was done on the regular string literal instead of the translated string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants