Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/main_window: fix switches Map Display frame to full screen mode by keyboard shortcut #2480

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jul 13, 2022

Describe the bug
Switches Map Display frame to full screen mode by keyboard shortcut F11 in single window mode is not working same as in multiple windows mode.

To Reproduce
Steps to reproduce the behavior:

  1. Launch wxGUI in single window mode
  2. Focus on Map Display frame
  3. Hit F11 keyboard shortcut
  4. Map Display frame doesn't switch to full screen mode

Expected behavior
Switches Map Display frame to full screen mode by keyboard shortcut F11 should be working in single window mode same as in multiple windows mode.

Screenshots

Expected behavior:

wxgui_map_disp_full_screen_with_key_shortcut_expected

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: 8.3, 8.4.dev

@tmszi tmszi added bug Something isn't working GUI wxGUI related labels Jul 13, 2022
@tmszi tmszi added this to the 8.2.1 milestone Jul 13, 2022
@tmszi tmszi marked this pull request as draft July 13, 2022 06:49
@neteler neteler modified the milestones: 8.2.1, 8.2.2 Jan 22, 2023
@wenzeslaus wenzeslaus modified the milestones: 8.2.2, 8.3.1 Jun 6, 2023
@tmszi tmszi modified the milestones: 8.3.1, 8.4.0 Sep 27, 2023
@tmszi tmszi force-pushed the fix_wxgui_single_win_mode_map_disp_full_screen branch from 72a867e to d0d0653 Compare December 19, 2023 09:14
@tmszi tmszi marked this pull request as ready for review December 19, 2023 09:23
@echoix echoix force-pushed the fix_wxgui_single_win_mode_map_disp_full_screen branch from d51c0c3 to f5fb99b Compare March 31, 2024 02:16
@github-actions github-actions bot added the Python Related code is in Python label Mar 31, 2024
… by keyboard shortcut

Hides toolbars, statusbar and panes with keyboard shortcut F11 in
single window mode.
@echoix echoix force-pushed the fix_wxgui_single_win_mode_map_disp_full_screen branch from f5fb99b to e2f572f Compare April 24, 2024 02:06
Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be updated after #3003

"""Switches Map Display frame to full-screen mode, hides toolbars,
statusbar and panes
"""
mapdisplay = self.mapnotebook.GetCurrentPage()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the mapnotebook got renamed.

@petrasovaa petrasovaa modified the milestones: 8.4.0, 8.4.1 May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants