Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10n: Avoid using deprecated locale.getdefaultlocale() #2550

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

pesekon2
Copy link
Contributor

@pesekon2 pesekon2 self-assigned this Aug 27, 2022
@pesekon2 pesekon2 added this to In progress in OSGeo Community Sprint 2022 via automation Aug 27, 2022
@neteler
Copy link
Member

neteler commented Aug 27, 2022

Could maybe @landam or @hellik (or others) test this on Windows? Thanks!

@hellik
Copy link
Member

hellik commented Aug 27, 2022

Could maybe @landam or @hellik (or others) test this on Windows? Thanks!

Not able to test this on this weekend. @landam any chance to test?

@neteler neteler added the Python Related code is in Python label Aug 28, 2022
@neteler neteler added this to the 8.3.0 milestone Aug 28, 2022
@pesekon2 pesekon2 merged commit 2378fbe into OSGeo:main Sep 17, 2022
OSGeo Community Sprint 2022 automation moved this from In progress to Done Sep 17, 2022
@pesekon2 pesekon2 deleted the avoid_deprecated_getdefaultlocale branch September 17, 2022 08:35
@nilason
Copy link
Contributor

nilason commented Dec 2, 2022

Is it possible to backport this to 8.2?
See #2677 .

@pesekon2
Copy link
Contributor Author

pesekon2 commented Dec 2, 2022

@nilason: Yes. Thanks. Backported in 722aaa0.

@pesekon2
Copy link
Contributor Author

pesekon2 commented Dec 2, 2022

Actually, the commit that really needed to be backported to fix that issue was c726ae1. Backported too, in 31a672d.

@neteler neteler modified the milestones: 8.3.0, 8.2.1 Dec 22, 2022
neteler pushed a commit that referenced this pull request May 29, 2023
Backport of #2550 to G78, fixing Python 3.11 error after deprecation.

* fix #2538
* Use getencoding() where only encoding is needed; getlocale() otherwise

Additional changes:
- sync of `tools/mkhtml.py` with `main` branch
- selected backport from #2140 to get `utils/generate_last_commit_file.py`
- selective sync of `lib/init/grass.py`
@wenzeslaus wenzeslaus changed the title avoid using deprecated locale.getdefaultlocale() L10n: Avoid using deprecated locale.getdefaultlocale() Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Related code is in Python
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

getdefaultlocale() deprecated in Python 3.11
4 participants