Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI: remove custom v.clean interface to simplify maintenance #2553

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

petrasovaa
Copy link
Contributor

The current v.clean GUI (not the autogenerated) is buggy, and the interface is not that intuitive either, so I suggest to remove it to ease the GUI maintenance. v.clean is still available from the GUI with the standard autogenerated interface.

@petrasovaa petrasovaa added the GUI wxGUI related label Aug 28, 2022
@petrasovaa petrasovaa added this to the 8.3.0 milestone Aug 28, 2022
@petrasovaa petrasovaa requested a review from metzm August 28, 2022 08:10
@wenzeslaus wenzeslaus added this to In progress in OSGeo Community Sprint 2022 via automation Aug 28, 2022
@petrasovaa petrasovaa merged commit d05e2c5 into OSGeo:main Oct 26, 2022
OSGeo Community Sprint 2022 automation moved this from In progress to Done Oct 26, 2022
@petrasovaa petrasovaa deleted the v.clean-remove-gui branch October 26, 2022 03:05
@metzm
Copy link
Contributor

metzm commented Nov 19, 2022

@petrasovaa A pity that the custom v.clean GUI has been removed: the purpose was to 1) set the order of the cleaning tools, 2) use the same tool repeatedly, optionally with different thresholds. With the autogenerated GUI, this is not possible.

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@wenzeslaus wenzeslaus removed the request for review from metzm November 9, 2023 18:49
@wenzeslaus
Copy link
Member

The way how we need to handle this is by using a widget in the auto-generated dialog which fits with how the tool parameter can be used (repetitions and order matters). We can't maintain a custom dialog just for this purpose. If need, we need to create a new fitting widget or even add more metadata to the parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants