Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctypes: Upgrade to ctypesgen version 1.1.1 #2598

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Oct 13, 2022

After almost 3 years, a new version of ctypesgen has been released: v1.1.0.
This PR aims to upgrade GRASS' embedded version to the very soon to be released
v1.1.1.

For GRASS there are not any major news with this, but some of them include:

  • Added support for sized integer types on Windows
  • Added support to handle function specifier keywords: inline and _Noreturn
  • Fixed mapping of 'short int' to c_short
  • Improved parsing of pragma directives

see https://github.com/ctypesgen/ctypesgen/compare/fd495e5..b686ef2 for upstream commit comparison.

Initially this is put up as a draft, as the actual release is still pending.

(Unfortunately, there are no GRASS patches eliminated with this.)

@BadAssassin
Copy link
Contributor

I have not tested it, but this looks like excellent work.

@nilason
Copy link
Contributor Author

nilason commented Oct 13, 2022

Looking at the CI logs, this doesn't affect much the GCC ubuntu builds with a couple of less parser "Error" messages. But on the Windows build there is a massive improvement: more than half of the parser error messages are gone!

@nilason nilason marked this pull request as ready for review October 19, 2022 07:40
@nilason
Copy link
Contributor Author

nilason commented Oct 19, 2022

ctypesgen v1.1.1 is now released. This is now open.

@nilason nilason added this to the 8.3.0 milestone Oct 20, 2022
@nilason nilason added QGIS Highly related to QGIS or specific to QGIS Python Related code is in Python and removed QGIS Highly related to QGIS or specific to QGIS labels Oct 20, 2022
@nilason
Copy link
Contributor Author

nilason commented Oct 27, 2022

If there are no objections, I will soon move forward and merge this PR.

@nilason nilason merged commit 7ccc717 into OSGeo:main Oct 28, 2022
@nilason nilason deleted the upd_ctypesgen_1.1.1 branch October 28, 2022 08:03
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
Notable changes are
- Added support for sized integer types on Windows
- Added support to handle function specifier keywords: inline and _Noreturn
- Fixed mapping of 'short int' to c_short
- Improved parsing of pragma directives
marisn pushed a commit to marisn/grass that referenced this pull request Jun 2, 2023
Notable changes are
- Added support for sized integer types on Windows
- Added support to handle function specifier keywords: inline and _Noreturn
- Fixed mapping of 'short int' to c_short
- Improved parsing of pragma directives
@wenzeslaus wenzeslaus changed the title Upgrade to ctypesgen version 1.1.1 ctypes: Upgrade to ctypesgen version 1.1.1 Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Notable changes are
- Added support for sized integer types on Windows
- Added support to handle function specifier keywords: inline and _Noreturn
- Fixed mapping of 'short int' to c_short
- Improved parsing of pragma directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants