r.in.pdal: Fix use of PDAL 2.4 deprecated api #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work fine, only one call: |
nilason
changed the title
|
Now this replicates PDAL pre-2.4 behaviour for r.in.pdal. I have tested with 2.3.0 and 2.4.2; the CI builds fine with 2.0.1. |
|
If possible, could this be backported? In various distros G8.2 will stay for a while... |
Shouldn't be any problem! |
nilason
added
backport_needed
bug
marisn
approved these changes
Nov 17, 2022
nilason
added a commit
that referenced
this pull request
Nov 21, 2022
Fixes LasHeader info printout, re-used code from PDAL 2.3: https://github.com/PDAL/PDAL/blob/2.3.0/io/LasHeader.cpp#L524
|
Merged and backported. Thanks @marisn ! |
That is backported to 8.2 |
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
Fixes LasHeader info printout, re-used code from PDAL 2.3: https://github.com/PDAL/PDAL/blob/2.3.0/io/LasHeader.cpp#L524
marisn
pushed a commit
to marisn/grass
that referenced
this pull request
Jun 2, 2023
Fixes LasHeader info printout, re-used code from PDAL 2.3: https://github.com/PDAL/PDAL/blob/2.3.0/io/LasHeader.cpp#L524
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
Fixes LasHeader info printout, re-used code from PDAL 2.3: https://github.com/PDAL/PDAL/blob/2.3.0/io/LasHeader.cpp#L524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-used code from PDAL 2.3:
https://github.com/PDAL/PDAL/blob/2.3.0/io/LasHeader.cpp#L524
Fixes #2638