Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.maxlik: fix crash when classification result is NULL #2724

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

marisn
Copy link
Contributor

@marisn marisn commented Jan 2, 2023

If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.

@marisn marisn added bug Something isn't working C Related code is in C labels Jan 2, 2023
@neteler neteler added this to the 8.3.0 milestone Jan 2, 2023
@marisn marisn merged commit e23f4d6 into OSGeo:main Jan 3, 2023
@marisn
Copy link
Contributor Author

marisn commented Jan 3, 2023

The erroneous code was present only in the main branch thus no backporting is required.

@marisn marisn deleted the fix_i_maxlik branch January 3, 2023 06:57
a0x8o added a commit to a0x8o/grass that referenced this pull request Jan 3, 2023
If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.
a0x8o added a commit to a0x8o/grass that referenced this pull request May 9, 2024
If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.
a0x8o added a commit to a0x8o/grass that referenced this pull request May 21, 2024
If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.
a0x8o added a commit to a0x8o/grass that referenced this pull request Jun 3, 2024
If any input cell from imagery group is NULL, the result of classification is also NULL. The implementation of original cat restoration (79f9500) did not check for this corner case and thus caused an out of bounds value access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working C Related code is in C
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants