checks: Add missing function prototypes #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
If there are no objections to this PR, I'll merge it in the next few days. |
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jan 23, 2023
This adds most, but not all, missing function prototypes. Aaron Ballman from llvm, summarise: (https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521): > Functions without prototypes have never been a recommended practice > in any standard version of C. In fact, they were introduced into C89 > as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+ > year deprecation period, C2x will be removing support for functions > with identifier list > (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be > changing the behavior of prototypeless functions with empty parentheses > to match the behavior of C++ (N 2841: No function declarators without > prototypes). a statement, which may provide as a short background as well as motivation for this commit.
ninsbl
pushed a commit
to ninsbl/grass
that referenced
this pull request
Feb 17, 2023
This adds most, but not all, missing function prototypes. Aaron Ballman from llvm, summarise: (https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521): > Functions without prototypes have never been a recommended practice > in any standard version of C. In fact, they were introduced into C89 > as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+ > year deprecation period, C2x will be removing support for functions > with identifier list > (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be > changing the behavior of prototypeless functions with empty parentheses > to match the behavior of C++ (N 2841: No function declarators without > prototypes). a statement, which may provide as a short background as well as motivation for this commit.
wenzeslaus
changed the title
neteler
pushed a commit
to nilason/grass
that referenced
this pull request
Nov 7, 2023
This adds most, but not all, missing function prototypes. Aaron Ballman from llvm, summarise: (https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521): > Functions without prototypes have never been a recommended practice > in any standard version of C. In fact, they were introduced into C89 > as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+ > year deprecation period, C2x will be removing support for functions > with identifier list > (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be > changing the behavior of prototypeless functions with empty parentheses > to match the behavior of C++ (N 2841: No function declarators without > prototypes). a statement, which may provide as a short background as well as motivation for this commit.
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
May 9, 2024
This adds most, but not all, missing function prototypes. Aaron Ballman from llvm, summarise: (https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521): > Functions without prototypes have never been a recommended practice > in any standard version of C. In fact, they were introduced into C89 > as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+ > year deprecation period, C2x will be removing support for functions > with identifier list > (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be > changing the behavior of prototypeless functions with empty parentheses > to match the behavior of C++ (N 2841: No function declarators without > prototypes). a statement, which may provide as a short background as well as motivation for this commit.
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
May 21, 2024
This adds most, but not all, missing function prototypes. Aaron Ballman from llvm, summarise: (https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521): > Functions without prototypes have never been a recommended practice > in any standard version of C. In fact, they were introduced into C89 > as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+ > year deprecation period, C2x will be removing support for functions > with identifier list > (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be > changing the behavior of prototypeless functions with empty parentheses > to match the behavior of C++ (N 2841: No function declarators without > prototypes). a statement, which may provide as a short background as well as motivation for this commit.
a0x8o
added a commit
to a0x8o/grass
that referenced
this pull request
Jun 3, 2024
This adds most, but not all, missing function prototypes. Aaron Ballman from llvm, summarise: (https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521): > Functions without prototypes have never been a recommended practice > in any standard version of C. In fact, they were introduced into C89 > as already being deprecated (see C89 3.9.4 and 3.9.5). After a 35+ > year deprecation period, C2x will be removing support for functions > with identifier list > (http://www.open-std.org/jtc1/sc22/wg14/www/docs/n2432.pdf) and will be > changing the behavior of prototypeless functions with empty parentheses > to match the behavior of C++ (N 2841: No function declarators without > prototypes). a statement, which may provide as a short background as well as motivation for this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds most, but not all, missing function prototypes.
Aaron Ballman, from llvm, summarise:
It is only a question of time before this must be fixed, but for a clearer and safer code I think there is no need to wait.
These fixes are trivial, but there were 4 files needing special attention and will be object for separate issues/pull requests.