introduce docker multistage build to alpine image #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
approved these changes
Jan 9, 2020
neteler
pushed a commit
that referenced
this pull request
Jan 9, 2020
introduce docker multistage build to alpine image, reducing significantly the image size
|
Excellent work, thanks! |
|
Backported to relbranch78 in 25f6035 |
landam
pushed a commit
to landam/grass
that referenced
this pull request
Jan 28, 2020
introduce docker multistage build to alpine image, reducing significantly the image size
petrasovaa
pushed a commit
to petrasovaa/grass
that referenced
this pull request
Feb 18, 2020
introduce docker multistage build to alpine image, reducing significantly the image size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, docker multistage-build is used for the alpine image. The order of the commands in the Dockerfile are only rearranged and a
COPYstatement was added. Additionally the environtment variable resolution forCMDwas fixed.Now there are the following stages:
FROM alpine:edge as common(includes build- and runtime requirements)FROM common as build(compiles GRASS GIS)FROM common as grass(Copies compiled code frombuild)FROM grass as test(Preprares tests)FROM grass as final(Finalizes small Dockerimage)As a result, the Dockerimage is much smaller (local build vs existing one from dockerhub):