Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: update of Debian image #2769

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Conversation

neteler
Copy link
Member

@neteler neteler commented Jan 21, 2023

  • Debian docker base image update
  • new versions:
Base image GRASS GIS PROJ GDAL PDAL Python Image size
Debian 11 8.3.dev 7.2.1 3.2.2 2.4.3 3.9.2 2.93 GB

LAZ-perf is enabled in PDAL, hence both LAS and LAZ files can be imported into GRASS GIS.

TODO in a separate PR: reduce image size

- Debian docker base image update
- new versions:

| Base image   | GRASS GIS  | PROJ  | GDAL  | PDAL  | Python | Image size |
|--------------|------------|-------|-------|-------|--------|------------|
| Debian 11    | 8.3.dev    | 7.2.1 | 3.2.2 | 2.4.3 | 3.9.2  | 2.93 GB    |
|--------------|------------|-------|-------|-------|--------|------------|

TODO in a separate PR: reduce image size
@neteler neteler added the docker Docker related label Jan 21, 2023
@neteler neteler added this to the 8.3.0 milestone Jan 21, 2023
@neteler neteler requested a review from tmszi January 21, 2023 11:09
@neteler neteler self-assigned this Jan 21, 2023
@neteler
Copy link
Member Author

neteler commented Jan 21, 2023

I hoped that the docker.yml would be triggered by it isn't...

Copy link
Member

@tmszi tmszi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image is created and the container is started.

@tmszi
Copy link
Member

tmszi commented Jan 21, 2023

I hoped that the docker.yml would be triggered by it isn't...

Because the trigger is enabled when pushing to a branch, not PR.

on:
push:
branches:
- 'main'
- 'releasebranch_*'
- '!releasebranch_7_*'
- 'releasebranch_7_8'
tags: ['*.*.*']
paths-ignore: ['doc/**']
release:
types: [published]

@neteler
Copy link
Member Author

neteler commented Jan 21, 2023

Because the trigger is enabled when pushing to a branch, not PR.

I see - should hat be changed? (in another PR)

@nilason
Copy link
Contributor

nilason commented Jan 21, 2023

Because the trigger is enabled when pushing to a branch, not PR.

I see - should hat be changed? (in another PR)

Discussed here:

#1790 (comment)

@neteler neteler merged commit d036ff8 into OSGeo:main Jan 22, 2023
@neteler neteler deleted the docker_debian_11_update branch January 22, 2023 19:25
neteler added a commit that referenced this pull request Jan 22, 2023
(backport of #2769)

- Debian docker base image update
- PDAL compilation: WITH_LASZIP=OFF, keep only WITH_LAZPERF=ON
- new versions:

| Base image   | GRASS GIS  | PROJ  | GDAL  | PDAL  | Python | Image size |
|--------------|------------|-------|-------|-------|--------|------------|
| Debian 11    | 8.2.dev    | 7.2.1 | 3.2.2 | 2.4.3 | 3.9.2  | 2.93 GB    |
|--------------|------------|-------|-------|-------|--------|------------|

TODO in a separate PR: reduce image size
@nilason
Copy link
Contributor

nilason commented Jan 22, 2023

Because the trigger is enabled when pushing to a branch, not PR.

I see - should hat be changed? (in another PR)

Discussed here:

#1790 (comment)

A tip. When I need to test something I'm not able to do locally, I temporally change in the relevant .yml file the following lines:

on:
  push:
    branches:
      - main
      - releasebranch_*
  pull_request:
    branches:
      - main
      - releasebranch_*

to:

on:
  - push
  - pull_request

and push it to a test fork (without creating PR).

@nilason
Copy link
Contributor

nilason commented Jan 22, 2023

and push it to a test fork (without creating PR).

I meant to say: "push to a test branch on my fork (without creating PR)".

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* docker: update of Debian image

- Debian docker base image update
* PDAL compilation: WITH_LASZIP=OFF, keep only WITH_LAZPERF=ON
- new versions:

| Base image   | GRASS GIS  | PROJ  | GDAL  | PDAL  | Python | Image size |
|--------------|------------|-------|-------|-------|--------|------------|
| Debian 11    | 8.3.dev    | 7.2.1 | 3.2.2 | 2.4.3 | 3.9.2  | 2.93 GB    |
|--------------|------------|-------|-------|-------|--------|------------|

TODO in a separate PR: reduce image size
neteler added a commit to nilason/grass that referenced this pull request Nov 7, 2023
* docker: update of Debian image

- Debian docker base image update
* PDAL compilation: WITH_LASZIP=OFF, keep only WITH_LAZPERF=ON
- new versions:

| Base image   | GRASS GIS  | PROJ  | GDAL  | PDAL  | Python | Image size |
|--------------|------------|-------|-------|-------|--------|------------|
| Debian 11    | 8.3.dev    | 7.2.1 | 3.2.2 | 2.4.3 | 3.9.2  | 2.93 GB    |
|--------------|------------|-------|-------|-------|--------|------------|

TODO in a separate PR: reduce image size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants