Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checks: pre-commit: add yaml file lint #2790

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

nilason
Copy link
Contributor

@nilason nilason commented Jan 27, 2023

This adds yaml linter https://github.com/adrienverge/yamllint and formatter https://github.com/jumanjihouse/pre-commit-hook-yamlfmt to .pre-commit-config.yaml.

All .yml files have also been fixed to pass without warning and formatted (for unified standard).

With CI's super-linter testing for yaml files, it is preferable to pre-empt any failures.

@nilason nilason added the enhancement New feature or request label Jan 27, 2023
@nilason nilason added this to the 8.3.0 milestone Jan 27, 2023
@nilason nilason changed the title pre-commit: add yaml file lint and format pre-commit: add yaml file lint Jan 29, 2023
@nilason
Copy link
Contributor Author

nilason commented Jan 29, 2023

I dropped the yamlfmt formatter from .pre-commit-config.yaml. I wasn’t convinced of its result in particular with the line-width changes. The linter should be quite enough for us.

@nilason nilason merged commit 6c1bdd7 into OSGeo:main Feb 1, 2023
@nilason nilason deleted the yaml-lint branch February 1, 2023 09:39
ninsbl pushed a commit to ninsbl/grass that referenced this pull request Feb 17, 2023
* max line-length is 120
* lint warnings have been fixed in all yaml files
@neteler neteler changed the title pre-commit: add yaml file lint checks: pre-commit: add yaml file lint Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
* max line-length is 120
* lint warnings have been fixed in all yaml files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant