-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wxGUI: Add copy path to mapset item in context menu #2865
Conversation
Please send a screenshot of the new GUI and fix the Flake8, Pylint, and Black errors reported by CI. I'm updating Black in a different PR, but that should not be a problem here. |
Please test it. I don't understand the changes you submitted, but they are certainly not copying the path to mapset to clipboard. See e.g. |
Great! Thank you for the information. I will incorporate the necessary changes in the PR. |
…ied the errors reported by CI
Hi @wenzeslaus, I'm having trouble opening the new GUI that I have been working on. I've tried running the program, but I haven't been able to get the GUI to open. Would you happen to have any resources or instructions that could help me get the GUI up and running? Any guidance or assistance you can provide would be greatly appreciated. Thank you! |
What did you try to run it? On macOS and Linux, you need to compile the source code. On Windows, for a small change like this, the easiest thing is to modify the file in your installation or get a virtual machine with Ubuntu. |
I am using windows , I went through the document of compile and install but I am not getting clear idea on how to compile and install the source code |
As I said, for a small first time change such as this, avoid compiling on Windows unless that's something you are familiar with, use an Ubuntu virtual machine or just edit the file in the installation after you installed the standard binary installer (from the website). |
Thank you so much @wenzeslaus for the info I will check right away |
Hey @wenzeslaus I installed GRASS GIS and I tried to find the context menu but I was not able to |
The menu on the screenshot is the correct one. You are using legacy version (7.8), you need to use more recent one, ideally the latest preview (8.3) to make the change in the right place. The preview version reflects the main branch of this repo on the day when it was build. |
Hey @wenzeslaus I am stuck on how to download 8.3 version as it is opening Index of/ page I searched the net and it is asking me to use wget to download the contents but cmd or windows powershell is not accepting the command can you please guide me |
https://wingrass.fsv.cvut.cz/grass83/ There are daily wingrass 8.3 builds; though stuck somewhere in the end of February. Right click on the latest build within the browser and save the exe. What is exactly your problem while downloading? |
Hey @hellik thanks for the info actually when I was trying to run the .exe file microsoft was not letting me to install an Unrecognized app so I turned the windows defender off and now the app is running fine |
In your case, it should be |
Can I now add a PR? |
The item when clicked puts the path to the clipboard and then we can paste it in the python script or CLI by paste option |
You should probably use |
Thank you so much for the info I will do the necessary changes right away |
Hey @petrasovaa I have made the necessary changes and I verified it by running the app |
Would you be so kind and NOT posting screenshots of code. Thank you! |
ok sorry won't do it again |
The easiest way in order to be able to track back is by using the "copy permalink" menu options at various places on the GitHub website. For example, selecting multiple lines (so they are yellow), and on the ..., choose Copy Permalink. If it's in the same repo, usually there will be a preview of the selected lines shown. |
Works fine! Please make the option also available for multiple mapsets, looks like your code already can do that, see |
Ok will add the necessary changes right away |
Hey @petrasovaa , Therefore, I would like to kindly request you to assign me other issues that you would want me to work on so that I can showcase my skills and potential to contribute to your organization. I believe that with additional assignments, I can demonstrate my commitment and capability to make meaningful contributions to your projects. Thank you for considering my request. |
Hey @wenzeslaus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you this looks good! I suggested just a small change in the label.
The mac os check failure is unrelated to this. |
This change resolves #2613 I added "copy path to mapset" item in context menu and added function "onCopyMapsetPath"
Please let me know if you have any further feedback or concerns.
Signed-off-by: Yousuf yousufmohd223@gmail.com