Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: fix compilation --with-openmp in MS Windows #2887

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

hellik
Copy link
Member

@hellik hellik commented Mar 13, 2023

fix #2885 by adapting package.sh

@hellik hellik requested review from landam and nilason March 13, 2023 22:42
@hellik hellik added Windows Microsoft Windows specific backport_needed labels Mar 13, 2023
@hellik
Copy link
Member Author

hellik commented Mar 13, 2023

anyone able to backport it then when PR is merged?

Copy link
Contributor

@nilason nilason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@neteler
Copy link
Member

neteler commented Mar 14, 2023

Great to see these improvements!

(would you mind to make the pull request title compliant with our release notes style? Then notes autogeneration will work much better)

@landam
Copy link
Member

landam commented Mar 14, 2023

Tested on build server:

x86_64-w64-mingw32-gcc -shared -o /usr/src/grass83/dist.x86_64-w64-mingw32/lib/libgrass_interpfl.8.3.dll -L/usr/src/grass83/dist.x86_64-w64-mingw32/lib -L/usr/src/grass83/dist.x86_64-w64-mingw32/lib -Wl,--export-dynamic,--enable-runtime-pseudo-reloc  -L/c/osgeo4w/lib   OBJ.x86_64-w64-mingw32/distance.o OBJ.x86_64-w64-mingw32/func2d.o OBJ.x86_64-w64-mingw32/init2d.o OBJ.x86_64-w64-mingw32/input2d.o OBJ.x86_64-w64-mingw32/interp2d.o OBJ.x86_64-w64-mingw32/matrix.o OBJ.x86_64-w64-mingw32/minmax.o OBJ.x86_64-w64-mingw32/output2d.o OBJ.x86_64-w64-mingw32/point2d.o OBJ.x86_64-w64-mingw32/resout2d.o OBJ.x86_64-w64-mingw32/ressegm2d.o OBJ.x86_64-w64-mingw32/secpar2d.o OBJ.x86_64-w64-mingw32/segmen2d.o OBJ.x86_64-w64-mingw32/segmen2d_parallel.o OBJ.x86_64-w64-mingw32/vinput2d.o OBJ.x86_64-w64-mingw32/write2d.o -lgrass_gis.8.3 -lintl -lgrass_raster.8.3 -lgrass_vector.8.3 -lgrass_gmath.8.3 -lgrass_dbmiclient.8.3 -lgrass_dbmibase.8.3  -lgrass_bitmap.8.3 -lgrass_qtree.8.3 -lgrass_interpdata.8.3   -lgomp  
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.3.0/../../../../x86_64-w64-mingw32/bin/ld.exe: warning: --export-dynamic is not supported for PE+ targets, did you mean --export-all-symbols?
if [ "" != "" -a -f "".html ] ; then make html ; fi
make[5]: Leaving directory '/usr/src/grass83/lib/rst/interp_float'

I am taking liberty to merge it.

@landam
Copy link
Member

landam commented Mar 14, 2023

@hellik Is backport really needed? GRASS82 seems to be compiled successfully: https://wingrass.fsv.cvut.cz/grass82/logs/log-r1e2ac5a211-207/error.log

@hellik
Copy link
Member Author

hellik commented Mar 14, 2023

@hellik Is backport really needed? GRASS82 seems to be compiled successfully: https://wingrass.fsv.cvut.cz/grass82/logs/log-r1e2ac5a211-207/error.log

See #2885 (comment)

It depends If the PR mentioned in this comment will be backported or not.

See also in the thread that the msys2 environment has to be adapted accordingly to avoid gcc/clang clash.

I'll merge later in the evening.

@neteler neteler changed the title fix winGRASS compilation regarding --with-openmp winGRASS: fix compilation regarding --with-openmp Mar 14, 2023
@landam
Copy link
Member

landam commented Mar 14, 2023

I'll merge later in the evening.

OK.

@hellik hellik changed the title winGRASS: fix compilation regarding --with-openmp configure: fix compilation --with-openmp in MS Windows Mar 14, 2023
@hellik hellik merged commit 3ec0d8d into OSGeo:main Mar 14, 2023
@hellik
Copy link
Member Author

hellik commented Mar 14, 2023

I'll merge later in the evening.

OK.

done.

@landam @nilason @neteler still open is discussion if #2692 will be applied to 8.2. if yes, then this PR has to be backported.

ninsbl pushed a commit to ninsbl/grass that referenced this pull request Mar 20, 2023
@landam landam added this to the 8.3.0 milestone Jun 6, 2023
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] winGRASS 8.3.dev compilation fails with --with-openmp
4 participants