Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.extrude: do not require height/height_column if elevation specified #2911

Merged
merged 1 commit into from
Apr 7, 2023
Merged

v.extrude: do not require height/height_column if elevation specified #2911

merged 1 commit into from
Apr 7, 2023

Conversation

landam
Copy link
Member

@landam landam commented Apr 1, 2023

Currently v.extrude requires height or height_column to be set even when elevation is specified:

v.extrude in=stream1 out=stream3d1 elevation=dem10m --o
ERROR: One of 'height' or 'height_column' parameters must be set

Expected behaviour

v.extrude in=stream1 out=stream3d1 elevation=dem10m --o
WARNING: Vector map <stream3d1> already exists and will be overwritten
Extruding features...
 100%
Copying attribute table...
Building topology for vector map <stream3d1@test>...
Registering primitives...
v.extrude complete. T: 392.161499 B: 0.000000.

v.extrude in=stream1 out=stream3d1 --q

ERROR: At least one of the following options is required: <height>, <height_column> and <elevation>

@landam landam added bug Something isn't working vector Related to vector data processing labels Apr 1, 2023
@landam landam added this to the 8.2.2 milestone Apr 1, 2023
@landam landam self-assigned this Apr 1, 2023
wenzeslaus
wenzeslaus approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense and the code seems to assume that's how the inputs can be structured. Thanks.

@wenzeslaus
Copy link
Member

I'm not sure about the milestone. Are you planning to backport it? Will 8.3.0 be released instead of 8.2.2?

@landam landam changed the title do not require height/height_column if elevation specified v.extrude: do not require height/height_column if elevation specified Apr 7, 2023
@landam landam merged commit 6d461f8 into OSGeo:main Apr 7, 2023
21 checks passed
@landam landam deleted the v_extrude_elevation branch April 7, 2023 07:46
landam added a commit that referenced this pull request Apr 7, 2023
@landam
do not require height/height_column if elevation specified (#2911)
b3a3328
@landam
Copy link
Member Author

landam commented Apr 7, 2023

I took liberty to backport this PR into current release branch (it's a bug fix).

neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
@landam @neteler
do not require height/height_column if elevation specified (OSGeo#2911)
13c48a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus approved these changes

@neteler neteler Awaiting requested review from neteler

Assignees

@landam landam

Labels
bug Something isn't working vector Related to vector data processing
Projects
None yet
Milestone
8.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@landam @wenzeslaus