Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Switch Travis to Ubuntu 22.04 (jammy) #3002

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

wenzeslaus
Copy link
Member

Default Python version reported by Travis for 20.04 is 3.7.13. While that's still a supported version for 8.3 release if it would be released now, 2023-06-27 is end of support for 3.7, so it seems safe to not test the main branch with 3.7 at this point.

Ubuntu 22.04 in Travis uses Python 3.10 by default according to the documentation.

Default Python version reported by Travis for 20.04 is 3.7.13. While that's still a supported version for 8.3 release if it would be released now, 2023-06-27 is end of support for 3.7, so it seems safe to not test the main branch with 3.7 at this point.

Ubuntu 22.04 in Travis uses Python 3.10 by default according to the documentation.
@wenzeslaus wenzeslaus added the CI Continuous integration label Jun 4, 2023
@neteler neteler added this to the 8.4.0 milestone Aug 16, 2023
@landam landam self-requested a review November 19, 2023 11:11
landam
landam previously requested changes Nov 19, 2023
Copy link
Member

@landam landam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts must be solved.

@echoix
Copy link
Member

echoix commented Dec 23, 2023

I verified that the file used that lists the dependencies included the change that was conflicting, it removed python-six and python-six was also removed from that file.

@echoix echoix dismissed landam’s stale review December 23, 2023 15:42

Conflicts were resolved manually, so review was addressed

Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I investigated the Travis failure and include a fix, but needs to be committed as I can't add an suggestion on lines not changed in the PR.

.travis/linux.install.sh Show resolved Hide resolved
@echoix echoix changed the title CI: Switch Travis to Ubuntu 22.04 (jammmy) CI: Switch Travis to Ubuntu 22.04 (jammy) Dec 23, 2023
@echoix
Copy link
Member

echoix commented Dec 27, 2023

@wenzeslaus I made a PR to your branch with the fixes that I found were needed but couldn't apply a suggestion on the lines.

wenzeslaus#3

@echoix
Copy link
Member

echoix commented Feb 8, 2024

Pinging back, so you could take a look at the PR in your fork targetting this branch, at the time that I made the changes it would have fixed the blockers in the PR and would make it ready to merge.

@wenzeslaus
Copy link
Member Author

Thanks @echoix. The Bash helped. If you want to take over here. Feel free to edit the branch directly. In any case, the current state is that it fails with PDAL (I didn't investigate):

checking whether to use PDAL... yes
configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library.

@echoix
Copy link
Member

echoix commented Feb 9, 2024

Can you make sure that the box allow edits by maintainers is checked? I think I tried and it didn't work at the time

echoix
echoix previously approved these changes Feb 14, 2024
@wenzeslaus
Copy link
Member Author

Both are on "Maintainers are allowed to edit this pull request." and "Allow edits and access to secrets by maintainers"

@echoix echoix self-assigned this Mar 8, 2024
@echoix
Copy link
Member

echoix commented Mar 11, 2024

I'm investigating on lost time here and then when I get an idea.

What I realized is that on Github CI, we use pdal 2.3.0 from ubuntu jammy. We never really built with pdal 2.6.2. Are we sure that our conifgure script works with pdal 2.6.3, or anything past 2.3.0? If someone could answer that, it might save me a little investigation instead of trying to get that answer by myself.

@neteler
Copy link
Member

neteler commented Mar 11, 2024

I have tried your changes in a ubuntu:jammy docker session and all got installed (PDAL 2.3.0).
On my local Fedora box I have PDAL 2.5.6. No experience yet with 2.6.3 but why should it be a problem (now)?

According to https://repology.org/project/pdal/versions a few distros already include 2.6.3 but I didn't try that.

@echoix
Copy link
Member

echoix commented Mar 11, 2024

It's (one of) the only place where we are building with ubuntugis unstable. Ubuntugis unstable gives 2.6.3. It had a new build between Thursday and this weekend, since a problem with a plugin package caused QGIS problems. But it shouldn't be that related, it was CMake stuff if I understand correctly.

I don't know the purpose of the Travis builds, so at least keeping it different of the GitHub Actions builds we already is important I think. Ubuntu 22.04 on GitHub gives us 2.3.0 from Ubuntu's default repos.

@wenzeslaus
Copy link
Member Author

I don't know the purpose of the Travis builds,

The Travis build was there before GitHub Actions were available. Then there was some time when GHA were broken and Travis provided the only (backup?) CI check (visual and doable as there were no required checks). Now perhaps, the value is in having another CI in place, so if our primary one goes away, we have a backup ready to go. I think I have seen even with Travis, but definitively in other cases that differences in configuration or tooling (and some duplication) make the CI more robust overall (e.g., one run is okay but another fails because of just slightly older dependency).

so at least keeping it different of the GitHub Actions builds we already is important I think.

That seems to be a valid approach. ...if you think it is not too much trouble for the one or two above values it provides.

@echoix
Copy link
Member

echoix commented Mar 21, 2024

Ok, it seems like an incompatibility of some sort with a newer PDAL or with the ubuntugis PPA (that provides a newer PDAL version). Disabling the ubuntugis ppa allows the ./configure call to succeed. It shouldn’t be an issue limited to Travis. It should be possible to reproduce somewhere else.

Our builds not being successful with the Ubuntugis ppa is somewhat problematic in my opinion

@neteler
Copy link
Member

neteler commented Mar 22, 2024

Ok, it seems like an incompatibility of some sort with a newer PDAL or with the ubuntugis PPA (that provides a newer PDAL version).

Is the error anywhere visible?

PDAL 2.7.0 just hit Fedora (https://src.fedoraproject.org/rpms/PDAL/c/3f731663ed3cbd4fbbacf475c1fb9a1bb0492b24?branch=rawhide), apparently without problems.

@wenzeslaus wenzeslaus modified the milestones: 8.4.0, Future Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants