wxGUI: Default Single-Window size is too small #3024

lindakarlovska · 2023-06-05T11:48:34Z

pesekon2 · 2023-06-06T11:50:43Z

Fixes the problem for me. @tmszi does it fix also your TypeError from #3013?

lindakarlovska · 2023-06-06T13:19:23Z

Fixes the problem for me. @tmszi does it fix also your TypeError from #3013?

@pesekon2 Most likely, it is not going to help. The MenuItem error has nothing to do with the size of Single Window. I would suggest creating a different PR for it.

petrasovaa · 2023-06-06T15:53:45Z

Should this go to 8.3 release? It looks like a an important fix. Why is it draft? The TypeError is unrelated.

lindakarlovska · 2023-06-06T19:03:40Z

Should this go to 8.3 release? It looks like a an important fix. Why is it draft? The TypeError is unrelated.

Yes, it should go to the release 8.3.0, I initially set it up for version 8.3.0.

This is a draft because I would like to test it more (it was very fast written).

landam · 2023-06-07T14:11:56Z

Single Window should probably start maximized by default. @lindakladivova @petrasovaa Any opinion?

lindakarlovska · 2023-06-07T17:46:05Z

Single Window should probably start maximized by default. @lindakladivova @petrasovaa Any opinion?

Well @landa, it actually is maximized by default but the problem is that we take the parameter defWindowPos (set by globalvar.GM_WINDOW_SIZE variable) from UserSettings if defined (rows 181 - 196). You can go to Settings -> General -> and check Suppress positioning Layer Manager window, close GRASS and start again and it will launch as maximized.

IMHO This User setting does not make sense for Single-Window, I would suggest removing rows 181 - 196 in frame/main_window.py. @petrasovaa what do you think?

Reminding me another thing (not related to this PR but also important): after the successful merge of #2667 we could finally remove the lmgr/frame.py file and possibly some other stuff like globalvar.GM_WINDOW_SIZE. Any opinions on this?

Further, I have one more thing here, I would like to try to suppress the GTK warnings as @vero mentioned... it is also painful but I will at least try it and we will see..

tmszi · 2023-06-07T19:54:52Z

Well @landa, it actually is maximized by default but the problem is that we take the parameter defWindowPos (set by globalvar.GM_WINDOW_SIZE variable) from UserSettings if defined (rows 181 - 196). You can go to Settings -> General -> and check Suppress positioning Layer Manager window, close GRASS and start again and it will launch as maximized.

By default without using this PR, single window mode size depend on the DE, respectively the type of window layout (floating, tiled, monocle) and OS wxGTK, wxMSW.

wxMSW (floating windows layout) default single window size and position:

wxGTK (floating windows layout with dwm window manager) default single window size and position (issue #3013):

wxGTK (tiled/monocle windows layout with dwm window manager) default single window size and position:

wxGTK (floating windows layout with Gnome DE) default single window size and position:

Important user settings is Save current window layout as default which works as expected. You can change position and size of window (single window mode too).

IMHO This User setting does not make sense for Single-Window, I would suggest removing rows 181 - 196 in frame/main_window.py. @petrasovaa what do you think?

It is not a good idea, if you remove these lines, the wxGUI single window mode will not respect the client area and will be overlapped by the DE panel(s).

pesekon2 · 2023-06-08T07:08:23Z

Further, I have one more thing here, I would like to try to suppress the GTK warnings as @vero mentioned... it is also painful but I will at least try it and we will see..

This would be the best thing to happen in GRASS for many years, in my eyes (I have the experience that when the users see those warnings and criticals, they consider GRASS to be broken and stop using it). Have had a discussion about that with @wenzeslaus and he can give a verbose, loquacious monologue on that. But we shouldn't make this issue a discussion forum keep sticking to the topic.

tmszi · 2023-06-08T18:55:09Z

Seems it is regression between revisions (respectively GRASS GIS versions)

Single window mode launch in the full screen mode by default with GRASS GIS version 8.3.0dev

wxGTK (floating windows layout with Gnome DE) default single window size and position:

GRASS world_latlong_wgs84/PERMANENT:~ > g.version -g
version=8.3.0dev
date=2023
revision=567ea066bd
build_date=2023-06-07

Single window mode doesn't launch in the full screen mode by default with GRASS GIS version 8.4.0dev

wxGTK (floating windows layout with Gnome DE) default single window size and position:

GRASS world_latlong_wgs84/PERMANENT:~ > g.version -g
version=8.4.0dev
date=2023
revision=24fd2a38f4
build_date=2023-06-08

lindakarlovska · 2023-06-09T15:12:24Z

@tmszi I will try to explain how I understand the problem, I might be wrong, please correct me.

The size of wx.Frame is in the constructor given by wx.Display().GetGeometry().GetSize() by default (in my case e.g. (1920, 1080)).

But the problem is that after calling self.Fit(), for some reason, the size of the main window is being changed and this is why I removed all self.Fit() callings. Not sure what happened between 8.3.0dev and 8.4.0dev versions but suddenly self.Fit() did not work.

But! When I tested this Pull request I was quite annoyed by the fact that even after removing the Fit() calling, I could not reach the maximized extent (1920, 1080). The problem was that I was actually still overwriting the desired extent by the extent I had saved in the UserSettings (rows 181-197).

Maybe I am not right, but I think that using just wx.Display().GetGeometry().GetSize() could be enough for setting the size of the main window. (I went from the fact that also other software I use always starts over the whole screen at the beginning), I think that making Single-Window smaller and saving the adapted extent into the User Settings does not make much sense...

But we can let it as it is, I have no problem with that. I was just critically thinking about the code and if these 17 rows have some meaning..

lindakarlovska · 2023-06-09T15:19:34Z

Further, I have one more thing here, I would like to try to suppress the GTK warnings as @vero mentioned... it is also painful but I will at least try it and we will see..

This would be the best thing to happen in GRASS for many years, in my eyes (I have the experience that when the users see those warnings and criticals, they consider GRASS to be broken and stop using it). Have had a discussion about that with @wenzeslaus and he can give a verbose, loquacious monologue on that. But we shouldn't make this issue a discussion forum keep sticking to the topic.

@pesekon2 I have spent two hours thinking about how to suppress these GTK warnings when launching GRASS and no results. I just succeeded in making more of them :)...

wenzeslaus · 2023-06-10T06:17:17Z

...I would like to try to suppress the GTK warnings as @vero mentioned... it is also painful but I will at least try it and we will see..

This would be the best thing to happen in GRASS for many years, in my eyes (I have the experience that when the users see those warnings and criticals, they consider GRASS to be broken and stop using it). Have had a discussion about that with @wenzeslaus and he can give a verbose, loquacious monologue on that...

...I have spent two hours thinking about how to suppress these GTK warnings when launching GRASS and no results...

#3049 removes the stderr when GUI is started together with GRASS GIS (not for g.gui).

tmszi · 2023-06-10T07:36:36Z

@tmszi I will try to explain how I understand the problem, I might be wrong, please correct me.

The size of wx.Frame is in the constructor given by wx.Display().GetGeometry().GetSize() by default (in my case e.g. (1920, 1080)).

But the problem is that after calling self.Fit(), for some reason, the size of the main window is being changed and this is why I removed all self.Fit() callings. Not sure what happened between 8.3.0dev and 8.4.0dev versions but suddenly self.Fit() did not work.

But! When I tested this Pull request I was quite annoyed by the fact that even after removing the Fit() calling, I could not reach the maximized extent (1920, 1080). The problem was that I was actually still overwriting the desired extent by the extent I had saved in the UserSettings (rows 181-197).

Maybe I am not right, but I think that using just wx.Display().GetGeometry().GetSize() could be enough for setting the size of the main window. (I went from the fact that also other software I use always starts over the whole screen at the beginning), I think that making Single-Window smaller and saving the adapted extent into the User Settings does not make much sense...

But we can let it as it is, I have no problem with that. I was just critically thinking about the code and if these 17 rows have some meaning..

@lindakladivova First thanks for your explanation.

I attached my patch which solve two issues:

Maximize single window mode by default
Respect user custom window position and size (custom win pos and size for single win mode is saved as standalone settings separate from multi win mode settings) changed via wxGUI Preference dialog Save current window layout as default checkbox widget

git am 0001-wxGUI-main_window-maximize-window-by-default.patch

0001-wxGUI-main_window-maximize-window-by-default.patch.zip

tmszi · 2023-06-18T13:51:58Z

Tested on Gentoo with dwm with activated floating window mode and wxGUI has been launched maximized by default and custom user settings (win position and size) works as expected too.

petrasovaa

I tested this with multi-window and currently it ignores the map display size and position, because IsDocked is True for mutli-window. This should fix it:

--- a/gui/wxpython/gui_core/preferences.py
+++ b/gui/wxpython/gui_core/preferences.py
@@ -1853,7 +1853,9 @@ class PreferencesDialog(PreferencesBaseDialog):
 
                 # window size must be larger than zero, not minimized
                 # do not save dim when mapdisp is docked within single window
-                if not mapdisp.IsDocked() and (size[0] > 0 and size[1] > 0):
+                if (not mapdisp.IsDockable() or not mapdisp.IsDocked()) and (
+                    size[0] > 0 and size[1] > 0
+                ):
                     dim += f",{pos[0]},{pos[1]},{size[0]},{size[1]}"
 
             if single_window:

landam · 2023-06-20T07:10:59Z

I tested multi-window with the patch above applied.

started GUI in multi-window layout
changed windows position
go to preferences, save
restart GUI

Windows appeared in original position, new position was ignored.

It seems that there is still an issue.

landam

multi-window position is ignored

landam · 2023-06-20T07:15:11Z

I have

"dim": "26,23,634,622,26,23,827,676",

in settings regardless how I organize windows.

landam · 2023-06-20T07:22:46Z

Strangely, when I change size of windows it works. But position is always the same:

26,23,866,802,26,23,951,762

landam · 2023-06-20T07:28:02Z

GetPosition() always returns (26,23) in my case (wxpython 4.2.0). But it seems to be not related to this PR.

gui/wxpython/gui_core/preferences.py

gui/wxpython/main_window/frame.py

lindakarlovska · 2023-06-20T16:58:22Z

GetPosition() always returns (26,23) in my case (wxpython 4.2.0). But it seems to be not related to this PR.

Yep, that's unrelated (probably a wxPython 4.2.0 error).

petrasovaa · 2023-06-20T20:03:11Z

GetPosition() always returns (26,23) in my case (wxpython 4.2.0). But it seems to be not related to this PR.

Yep, that's unrelated (probably a wxPython 4.2.0 error).

For me the position is saved as expected, I also use wxPython 4.2.0, so I am unsure why it doesn't work.

Review done

Maximize or set dimensions from user settings.

petrasovaa · 2023-06-21T09:00:49Z

In the interest of timely release I took liberty to merge and backport to 8_3 branch.

Maximize or set dimensions from user settings.

issue in Fix method

56d7363

lindakarlovska mentioned this pull request Jun 5, 2023

[Bug] Default single-window size is too small to see anything #3013

Closed

lindakarlovska self-assigned this Jun 5, 2023

lindakarlovska added GUI wxGUI related bug Something isn't working labels Jun 5, 2023

lindakarlovska added this to the 8.3.0 milestone Jun 5, 2023

simplification

1c975eb

petrasovaa requested a review from pesekon2 June 5, 2023 14:28

wenzeslaus modified the milestones: 8.3.0, 8.3.1 Jun 6, 2023

lindakarlovska marked this pull request as draft June 6, 2023 13:26

landam added the backport to 8.3 PR needs to be backported to release branch 8.3 label Jun 7, 2023

landam modified the milestones: 8.3.1, 8.4.0 Jun 7, 2023

petrasovaa mentioned this pull request Jun 8, 2023

[Bug] Grass GUI under Wayland too large for screen #3000

Open

black

be5e3d1

lindakarlovska marked this pull request as ready for review June 9, 2023 15:20

pesekon2 approved these changes Jun 18, 2023

View reviewed changes

petrasovaa requested changes Jun 18, 2023

View reviewed changes

landam previously requested changes Jun 20, 2023

View reviewed changes

landam reviewed Jun 20, 2023

View reviewed changes

gui/wxpython/gui_core/preferences.py Outdated Show resolved Hide resolved

nilason reviewed Jun 20, 2023

View reviewed changes

gui/wxpython/main_window/frame.py Show resolved Hide resolved

Anna's patch

12de5f6

lindakarlovska force-pushed the wxGUI-default-single-layout-size-too-small branch from a67fe98 to bc9f85b Compare June 20, 2023 16:45

maximized could be reached in the first run

f505365

lindakarlovska force-pushed the wxGUI-default-single-layout-size-too-small branch from bc9f85b to f505365 Compare June 20, 2023 16:53

lindakarlovska requested review from petrasovaa and landam June 20, 2023 16:57

petrasovaa approved these changes Jun 20, 2023

View reviewed changes

nilason approved these changes Jun 20, 2023

View reviewed changes

petrasovaa modified the milestones: 8.4.0, 8.3.0 Jun 21, 2023

petrasovaa merged commit 8a9e840 into OSGeo:main Jun 21, 2023
19 checks passed

petrasovaa pushed a commit that referenced this pull request Jun 21, 2023

wxGUI: Default Single-Window size is too small (#3024)

105b05b

Maximize or set dimensions from user settings.

petrasovaa removed the backport to 8.3 PR needs to be backported to release branch 8.3 label Jun 21, 2023

hjaekel mentioned this pull request Aug 4, 2023

[Bug] 'MapPanel' object has no attribute 'IsDockable' #3112

Closed

landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023

wxGUI: Default Single-Window size is too small (OSGeo#3024)

6f1aee0

Maximize or set dimensions from user settings.

neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023

wxGUI: Default Single-Window size is too small (OSGeo#3024)

efbcc69

Maximize or set dimensions from user settings.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wxGUI: Default Single-Window size is too small #3024

wxGUI: Default Single-Window size is too small #3024

lindakarlovska commented Jun 5, 2023

pesekon2 commented Jun 6, 2023

lindakarlovska commented Jun 6, 2023

petrasovaa commented Jun 6, 2023

lindakarlovska commented Jun 6, 2023

landam commented Jun 7, 2023

lindakarlovska commented Jun 7, 2023 •

edited

tmszi commented Jun 7, 2023 •

edited

pesekon2 commented Jun 8, 2023

tmszi commented Jun 8, 2023

lindakarlovska commented Jun 9, 2023 •

edited

lindakarlovska commented Jun 9, 2023 •

edited

wenzeslaus commented Jun 10, 2023

tmszi commented Jun 10, 2023

tmszi commented Jun 18, 2023 •

edited

petrasovaa left a comment

landam commented Jun 20, 2023

landam left a comment

landam commented Jun 20, 2023 •

edited

landam commented Jun 20, 2023

landam commented Jun 20, 2023

lindakarlovska commented Jun 20, 2023

petrasovaa commented Jun 20, 2023

petrasovaa commented Jun 21, 2023

wxGUI: Default Single-Window size is too small #3024

wxGUI: Default Single-Window size is too small #3024

Conversation

lindakarlovska commented Jun 5, 2023

pesekon2 commented Jun 6, 2023

lindakarlovska commented Jun 6, 2023

petrasovaa commented Jun 6, 2023

lindakarlovska commented Jun 6, 2023

landam commented Jun 7, 2023

lindakarlovska commented Jun 7, 2023 • edited

tmszi commented Jun 7, 2023 • edited

pesekon2 commented Jun 8, 2023

tmszi commented Jun 8, 2023

lindakarlovska commented Jun 9, 2023 • edited

lindakarlovska commented Jun 9, 2023 • edited

wenzeslaus commented Jun 10, 2023

tmszi commented Jun 10, 2023

tmszi commented Jun 18, 2023 • edited

petrasovaa left a comment

Choose a reason for hiding this comment

landam commented Jun 20, 2023

landam left a comment

Choose a reason for hiding this comment

landam commented Jun 20, 2023 • edited

landam commented Jun 20, 2023

landam commented Jun 20, 2023

lindakarlovska commented Jun 20, 2023

petrasovaa commented Jun 20, 2023

petrasovaa commented Jun 21, 2023

lindakarlovska commented Jun 7, 2023 •

edited

tmszi commented Jun 7, 2023 •

edited

lindakarlovska commented Jun 9, 2023 •

edited

lindakarlovska commented Jun 9, 2023 •

edited

tmszi commented Jun 18, 2023 •

edited

landam commented Jun 20, 2023 •

edited