-
-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i.ortho.target: Rename location and mapset options to target #3131
i.ortho.target: Rename location and mapset options to target #3131
Conversation
i.ortho.target has option target_location and mapset_location. This renames them to target_project and target_mapset, so the new names are consistent. While mapsets are in locations (projects), there seems to be no reason for the word location in mapset_location because it is G_OPT_M_MAPSET. This also includes change for g.gui.image2target which uses G_OPT_M_LOCATION with a custom name target_location, now renamed target_project. Both old and new names are consistent with target_project in i.ortho.target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with my suggestion for #2993, I again suggest that the word "Project" be capitalized in the label and description. It does not need to be capitalized in the key (i.e., command argument)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manual pages contain "location" as well.
i.ortho.target has option target_location and mapset_location. This renames them to target_project and target_mapset, so the new names are consistent. While mapsets are in locations (projects), there seems to be no reason for the word location in mapset_location because it is G_OPT_M_MAPSET.
This also includes change for g.gui.image2target which uses G_OPT_M_LOCATION with a custom name target_location, now renamed target_project. Both old and new names are consistent with target_project in i.ortho.target.