Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.ortho.target: Rename location and mapset options to target #3131

Merged
merged 5 commits into from
Mar 22, 2024

Conversation

wenzeslaus
Copy link
Member

i.ortho.target has option target_location and mapset_location. This renames them to target_project and target_mapset, so the new names are consistent. While mapsets are in locations (projects), there seems to be no reason for the word location in mapset_location because it is G_OPT_M_MAPSET.

This also includes change for g.gui.image2target which uses G_OPT_M_LOCATION with a custom name target_location, now renamed target_project. Both old and new names are consistent with target_project in i.ortho.target.

i.ortho.target has option target_location and mapset_location. This renames them to target_project and target_mapset, so the new names are consistent. While mapsets are in locations (projects), there seems to be no reason for the word location in mapset_location because it is G_OPT_M_MAPSET.

This also includes change for g.gui.image2target which uses G_OPT_M_LOCATION with a custom name target_location, now renamed target_project. Both old and new names are consistent with target_project in i.ortho.target.
@wenzeslaus wenzeslaus added enhancement New feature or request Python Related code is in Python C Related code is in C labels Aug 17, 2023
@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Aug 17, 2023
@wenzeslaus wenzeslaus mentioned this pull request Aug 18, 2023
6 tasks
Copy link
Contributor

@cmbarton cmbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with my suggestion for #2993, I again suggest that the word "Project" be capitalized in the label and description. It does not need to be capitalized in the key (i.e., command argument)

Copy link
Contributor

@petrasovaa petrasovaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The manual pages contain "location" as well.

@github-actions github-actions bot added HTML Related code is in HTML docs labels Mar 22, 2024
petrasovaa
petrasovaa previously approved these changes Mar 22, 2024
@petrasovaa petrasovaa enabled auto-merge (squash) March 22, 2024 17:48
@petrasovaa petrasovaa merged commit cb37ba7 into OSGeo:main Mar 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C docs enhancement New feature or request GUI wxGUI related HTML Related code is in HTML imagery libraries module Python Related code is in Python
Development

Successfully merging this pull request may close these issues.

None yet

3 participants