Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/animation: fix exporting an animation overlaid with custom image #3137

Merged

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Sep 2, 2023

Describe the bug
Exporting an animation overlaid with a custom image fails.

To Reproduce
Steps to reproduce the behavior:

  1. Launch animation tool wxGUI g.gui.animation
  2. Add some raster map(s) for creating animation
  3. Activate Export animation tool from the animation window toolbar
  4. On the Export animation dialog default Format page (tab) set output directory path for exported animation
  5. On the Export animation dialog switch to Decorations page (tab)
  6. Try to add some custom image (choose image file path)
  7. Hit Export button
  8. See error
Traceback (most recent call last):
  File
"/usr/lib64/grass84/gui/wxpython/animation/dialogs.py", line
1487, in OnExport

self.doExport.emit(
  File
"/usr/lib64/grass84/etc/python/grass/pydispatch/signal.py",
line 233, in emit

dispatcher.send(signal=self, *args, **kwargs)
  File "/usr/lib64/grass84/etc/python/grass/pydispatch/dispa
tcher.py", line 343, in send

response = robustapply.robustApply(
  File "/usr/lib64/grass84/etc/python/grass/pydispatch/robus
tapply.py", line 60, in robustApply

return receiver(*arguments, **named)
  File
"/usr/lib64/grass84/gui/wxpython/animation/controller.py",
line 618, in _export

image.Paste(decImage, x, y)
TypeError
:
Image.Paste(): argument 2 has unexpected type 'float'

Expected behavior
Exporting an animation overlaid with a custom image should work.

System description (please complete the following information):

  • Operating System: all
  • GRASS GIS version: all
test@test-gnu-linux:~$ python3 -c "import sys, wx; print(sys.version); print(wx.version())"
3.10.13 (main, Aug 25 2023, 20:13:27) [GCC 12.3.1 20230526]
4.2.0 gtk3 (phoenix) wxWidgets 3.2.2.1

Position (x, y coordinate) of overlaid image must be integer type.
@tmszi tmszi added backport to 8.3 PR needs to be backported to release branch 8.3 backport to 8.2 PR needs to be backported to release branch 8.2 labels Sep 2, 2023
@tmszi tmszi added this to the 8.3.1 milestone Sep 2, 2023
@tmszi tmszi added bug Something isn't working GUI wxGUI related labels Sep 2, 2023
@tmszi tmszi modified the milestones: 8.3.1, 8.4.0 Sep 3, 2023
@tmszi tmszi merged commit c5ab23c into OSGeo:main Sep 15, 2023
19 checks passed
tmszi added a commit to tmszi/grass that referenced this pull request Sep 15, 2023
OSGeo#3137)

Position (x, y coordinate) of overlaid image must be integer type.
tmszi added a commit to tmszi/grass that referenced this pull request Sep 15, 2023
OSGeo#3137)

Position (x, y coordinate) of overlaid image must be integer type.
@tmszi tmszi removed backport to 8.3 PR needs to be backported to release branch 8.3 backport to 8.2 PR needs to be backported to release branch 8.2 labels Sep 15, 2023
@tmszi tmszi deleted the wxgui_fix_export_animation_with_overlaid_img branch September 15, 2023 05:56
landam pushed a commit to landam/grass that referenced this pull request Oct 25, 2023
OSGeo#3137)

Position (x, y coordinate) of overlaid image must be integer type.
neteler pushed a commit to nilason/grass that referenced this pull request Nov 7, 2023
OSGeo#3137)

Position (x, y coordinate) of overlaid image must be integer type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GUI wxGUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants