Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.patch: Continuous cats with -e #3508

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

HuidaeCho
Copy link
Member

@HuidaeCho HuidaeCho commented Mar 15, 2024

This PR makes patched categories continuous. Without this PR:

v.random tmp100 npoints=100 seed=100
v.db.addtable tmp100 col="id varchar(20)"
v.db.update tmp100 col=id qcol="'tmp100_' || cat"

v.random tmp10 npoints=10 seed=10
v.db.addtable tmp10 col="id varchar(20)"
v.db.update tmp10 col=id qcol="'tmp10_' || cat"

v.patch tmp100,tmp10 out=tmp110 -e

v.category tmp110 op=report
Layer/table: 1/tmp110
type       count        min        max
point        110          2        112
line           0          0          0
boundary       0          0          0
centroid       0          0          0
area           0          0          0
face           0          0          0
kernel         0          0          0
all          110          2        112 # 2-101, 103-112

With this PR:

v.category tmp110 op=report
Layer/table: 1/tmp110
type       count        min        max
point        110          1        110
line           0          0          0
boundary       0          0          0
centroid       0          0          0
area           0          0          0
face           0          0          0
kernel         0          0          0
all          110          1        110 # 1-110

@HuidaeCho HuidaeCho self-assigned this Mar 15, 2024
@HuidaeCho HuidaeCho added the vector Related to vector data processing label Mar 15, 2024
@github-actions github-actions bot added C Related code is in C module labels Mar 15, 2024
@HuidaeCho HuidaeCho added enhancement New feature or request and removed C Related code is in C module labels Mar 15, 2024
@HuidaeCho HuidaeCho requested a review from cmbarton March 15, 2024 16:43
@neteler neteler added this to the 8.4.0 milestone Mar 15, 2024
@github-actions github-actions bot added C Related code is in C module labels Mar 15, 2024
@HuidaeCho
Copy link
Member Author

This PR partly addresses https://lists.osgeo.org/pipermail/grass-dev/2024-March/096233.html. In my test, all features were linked to cats.

@cmbarton
Copy link
Contributor

This PR partly addresses https://lists.osgeo.org/pipermail/grass-dev/2024-March/096233.html. In my test, all features were linked to cats.

This looks like it solves a major part of my issues. Thanks much. I'll try to compile and test very soon.

Copy link
Contributor

@cmbarton cmbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improves v.patch and works fine. So I recommend merging. However, there remain additional issues to solve.

@HuidaeCho
Copy link
Member Author

This improves v.patch and works fine. So I recommend merging. However, there remain additional issues to solve.

@wenzeslaus Is this a GitHub bug? With @cmbarton's approval, I should be able to merge it, but it still says Review required. Weird...

@cmbarton
Copy link
Contributor

cmbarton commented Mar 16, 2024 via email

@echoix
Copy link
Member

echoix commented Mar 17, 2024

I think it’s because I no longer have 'official' review to merge authorization.

Yes it is because of that. In these simple cases, when an external expert approves a PR but doesn't have the right permissions, someone else just comes in an approve afterwards, no big deal.

@HuidaeCho HuidaeCho merged commit 8130144 into OSGeo:main Mar 17, 2024
25 checks passed
@HuidaeCho HuidaeCho deleted the v_patch_continuous_cats branch March 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C enhancement New feature or request module vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants