Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(deps): Update dependency flake8 to v7 and use pipx to isolate tools #3818

Merged
merged 12 commits into from
Jun 19, 2024
Merged

CI(deps): Update dependency flake8 to v7 and use pipx to isolate tools #3818

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9fbfe85
CI(deps): Update dependency flake8 to v7
renovate[bot] Jun 17, 2024
790e29d
Use pipx to install Python packages
echoix Jun 17, 2024
34d11ed
Move pytest-github-actions-annotate-failures install near pytest install
echoix Jun 18, 2024
53c6a1b
Quote bandit[sarif] pipx install
echoix Jun 19, 2024
fba9a0f
Revert Quote bandit[sarif] pipx install
echoix Jun 19, 2024
247e889
Use Python 3.11 instead of requiring the toml extra for bandit
echoix Jun 19, 2024
13a80e3
Use Python 3.10 and add toml and sarif extra to bandit install
echoix Jun 19, 2024
3094fea
Inject other python packages into pylint's pipx environment
echoix Jun 19, 2024
94c0518
Inject pytest dependencies in pylint pipx env
echoix Jun 19, 2024
5ce7f06
Include app pytest into pylint's pipx env
echoix Jun 19, 2024
c848077
Split pytest-pylint pipx inject to not fail on no installable apps fo…
echoix Jun 19, 2024
2901acf
Split pytest-pylint pipx inject to not fail on no installable apps fo…
echoix Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/python-code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
# renovate: datasource=pypi depName=black
BLACK_VERSION: "24.4.2"
# renovate: datasource=pypi depName=flake8
FLAKE8_VERSION: "5.0.4"
FLAKE8_VERSION: "7.1.0"
# renovate: datasource=pypi depName=pylint
PYLINT_VERSION: "2.12.2"
# renovate: datasource=pypi depName=bandit
Expand Down Expand Up @@ -87,9 +87,13 @@
run: |
pip install -r .github/workflows/python_requirements.txt
pip install -r .github/workflows/optional_requirements.txt
pip install flake8==${{ env.FLAKE8_VERSION }}
pip install pylint==${{ env.PYLINT_VERSION }} pytest-github-actions-annotate-failures
pip install bandit[sarif]==${{ env.BANDIT_VERSION }}
pip install --user pipx
pipx ensurepath
pipx install flake8==${{ env.FLAKE8_VERSION }}
pipx install pylint==${{ env.PYLINT_VERSION }}
pipx inject pylint -r .github/workflows/python_requirements.txt -r .github/workflows/optional_requirements.txt
# The extra toml is only needed before Python 3.11
pipx install bandit[sarif,toml]==${{ env.BANDIT_VERSION }}

- name: Run Flake8
run: |
Expand Down Expand Up @@ -142,11 +146,12 @@
export PYTHONPATH=`grass --config python_path`:$PYTHONPATH
export LD_LIBRARY_PATH=$(grass --config path)/lib:$LD_LIBRARY_PATH
cd gui/wxpython
pylint --persistent=no --py-version=${{ env.MIN_PYTHON_VERSION }} --jobs=$(nproc) *

Check warning on line 149 in .github/workflows/python-code-quality.yml

View workflow job for this annotation

GitHub Actions / Python Code Quality Checks (ubuntu-22.04) 

  Temporarily downgraded pytest-pylint and pytest to allow merging other PRs.  The errors reported with a newer version seem legitimite and should be fixed   (2023-10-18, see https://github.com/OSGeo/grass/pull/3205)  (2024-01-28, see https://github.com/OSGeo/grass/issues/3380)

- name: Run Pylint on other files using pytest
run: |
pip install pytest==7.4.4 pytest-pylint==0.19
pipx inject --include-apps pylint pytest==7.4.4
pipx inject pylint pytest-pylint==0.19 pytest-github-actions-annotate-failures
echo "::warning file=.github/workflows/python-code-quality.yml,line=149,col=42,endColumn=48::\
Temporarily downgraded pytest-pylint and pytest to allow merging other PRs.\
The errors reported with a newer version seem legitimite and should be fixed \
Expand Down