Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.out.ogr: adds basic unit tests #3848

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

v.out.ogr: adds basic unit tests #3848

wants to merge 11 commits into from

Conversation

ldesousa
Copy link
Contributor

@ldesousa ldesousa commented Jun 16, 2024 •
edited by neteler
Loading

Test export and import of GeoPackage format.

@ldesousa ldesousa requested a review from wenzeslaus June 16, 2024 12:10
@github-actions github-actions bot added vector Related to vector data processing Python Related code is in Python module tests Related to Test Suite labels Jun 16, 2024
@ldesousa ldesousa mentioned this pull request Jun 17, 2024
Open
@neteler neteler changed the title Adds basic unit tests to v.out.ogr v.out.ogr: adds basic unit tests Jun 17, 2024
wenzeslaus
wenzeslaus requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a detail. Pylint would report the same.

vector/v.out.ogr/testsuite/test_v_out_ogr.py Outdated
"v.out.ogr",
"Export to GeoPackage Format",
input=self.test_map,
output="%s.gpkg" % self.test_map,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
output="%s.gpkg" % self.test_map,
output=f"{self.test_map}.gpkg"

Same also elsewhere.

@ldesousa ldesousa requested a review from wenzeslaus June 18, 2024 13:09
wenzeslaus
wenzeslaus reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@wenzeslaus wenzeslaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, see the other PR for comments on comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
module Python Related code is in Python tests Related to Test Suite vector Related to vector data processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldesousa @wenzeslaus