tools: Use 4 cores as default for parallelized tools #3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the common requests for parallelization by default and 4 cores (threads, processes) being most efficient, this is changing the default for nprocs for all tools to 4. The value can be changed in GUI settings or using g.gisenv using the NPROCS variable. This will require review of all test of tools with nprocs to make sure they are using nprocs=1 and not the default when parallelization is not tested.
ldesousa
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Even my cellphone has more than 4 cores. The only context in which this may be a nuisance is in HPC, where usually each process is assigned only one compute core. However, since the default behaviour is what newer users will have contact with I think this change is useful. In a HPC context more advanced users should be expected, aware of how tweak this setting.
|
Setting a mask will disable use of multiple processes if I understand well. Something easy to overlook as an end user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the common requests for parallelization by default and 4 cores (threads, processes) being most efficient, this is changing the default for nprocs for all tools to 4.
The value can be changed in GUI settings or using g.gisenv using the NPROCS variable.
This will require review of all test of tools with nprocs to make sure they are using nprocs=1 and not the default when parallelization is not tested. (This is in context of #3879.)