-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix copy-to-clipboard key binding for console (trac#3008) #393
Conversation
* fixes trac issue https://trac.osgeo.org/grass/ticket/3008, binding cmd+c to copy-to-clipboard in output console and python shell * fixes trac issue https://trac.osgeo.org/grass/ticket/3592, binding cmd+c to copy-to-clipboard import/export dialogs
Hi, unfortunately I am unable to test this on mac, but I felt this solution seems like too much workaround. Were you able to identify the actual cause of the problem? Is this something specifically in GRASS or it's more wx issue? For example, is that caused by some default bindings in wx.stc widget? If yes, there might be ways to address it directly using their methods (https://wxpython.org/Phoenix/docs/html/wx.stc.StyledTextCtrl.html). If it's related to wx, using the wx demo can sometimes help to find the issue. Also, the same workaround would be probably needed in forms.py for module dialogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
This is an old and still standing wxWidgets issue for mac, see: http://trac.wxwidgets.org/ticket/15678 and wxWidgets/Phoenix#1134. Presently, as far as I know, only a workaround can fix this and the solution I suggested is the least invasive I could think up. The added code can also be easily disposed of if fixed upstream. So far I could only observe this problem with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for more info. Then I guess we will have to go with this.
* fixes trac issue https://trac.osgeo.org/grass/ticket/3008, binding cmd+c to copy-to-clipboard in output console and python shell * fixes trac issue https://trac.osgeo.org/grass/ticket/3592, binding cmd+c to copy-to-clipboard import/export dialogs
Great, thanks! |
This PR addresses the trac#3008 issue, where cmd+c on macOS presently clear the output console instead of the (on macOS) expected outcome: copy-to-clipboard of selected text.
Tested on Windows and Mac.
Update: this also addresses trac#3592.